Skip to content

Run buildifier on some deps files - #56979

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
aiuto/bf
Sep 27, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
aiuto/bf

Conversation

@aiuto

@aiuto aiuto commented Sep 27, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

  • Runs buildifier on some overlay.BUILD.bazel files.
  • There is no behavior change.

Motivation

AI created PRs tend to run buildifier on build files that they touch. This creates changes that are hard to review because they have extra non-functional parts to look at. Running buildifier first helps makes those PR easier to understand.

Describe how you validated your changes

N/A

@aiuto aiuto added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Sep 27, 2026
@aiuto
aiuto requested a review from a team as a code owner September 27, 2026 03:43
@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Sep 27, 2026
@github-actions github-actions Bot added the medium review PR review might take time label Sep 27, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review by Codex (OpenAI) - workflow run

The patch is correct. The changes are formatting, attribute/list reordering, and equivalent Bazel label shorthand. No actionable regressions were identified. Validation was limited to static review; builds were not run.

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 62.38% (+2.17%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ca331c7 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 00b028b6:

Results for datadog-agent_7.85.0~devel.git.685.ca331c7.pipeline.140375052-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.85.0~devel.git.685.ca331c7.pipeline.140375052-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 00b028b
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
✅ agent_deb_amd64 782.819 MiB
✅ agent_deb_amd64_fips 717.216 MiB
✅ agent_heroku_amd64 317.588 MiB
✅ agent_msi 652.464 MiB
✅ agent_rpm_amd64 782.803 MiB
✅ agent_rpm_amd64_fips 717.200 MiB
✅ agent_rpm_arm64 753.715 MiB
✅ agent_rpm_arm64_fips 693.486 MiB
✅ agent_suse_amd64 782.803 MiB
✅ agent_suse_amd64_fips 717.200 MiB
✅ agent_suse_arm64 753.715 MiB
✅ agent_suse_arm64_fips 693.486 MiB
✅ docker_agent_amd64 840.698 MiB
✅ docker_agent_arm64 836.620 MiB
✅ docker_agent_jmx_amd64 1031.568 MiB
✅ docker_agent_jmx_arm64 1016.270 MiB
✅ docker_cws_instrumentation_amd64 7.439 MiB
✅ docker_cws_instrumentation_arm64 6.877 MiB
✅ docker_dogstatsd_amd64 39.394 MiB
✅ docker_dogstatsd_arm64 37.503 MiB
✅ docker_host_profiler_amd64 308.053 MiB
✅ docker_host_profiler_arm64 319.274 MiB
✅ dogstatsd_deb_amd64 30.138 MiB
✅ dogstatsd_deb_arm64 28.150 MiB
✅ dogstatsd_rpm_amd64 30.138 MiB
✅ dogstatsd_suse_amd64 30.138 MiB
✅ iot_agent_deb_amd64 46.595 MiB
✅ iot_agent_deb_arm64 43.217 MiB
✅ iot_agent_deb_armhf 44.037 MiB
✅ iot_agent_rpm_amd64 46.596 MiB
✅ iot_agent_suse_amd64 46.595 MiB
✅ docker_cluster_agent_amd64 213.638 MiB
✅ docker_cluster_agent_arm64 226.600 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: e9ad4607-072b-4303-8d90-45755b0340ff

Baseline: b9ff7bb
Comparison: 9ae3975
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_metrics_logs memory utilization +0.70 [+0.47, +0.93] 1 Logs bounds checks dashboard
➖ quality_gate_logs % cpu utilization +0.51 [-0.35, +1.37] 1 Logs bounds checks dashboard
➖ dsd_uds_10mb_3k_timestamped_contexts_cpu % cpu utilization +0.29 [+0.05, +0.53] 1 Logs
➖ quality_gate_security_mean_fs_load memory utilization +0.22 [+0.17, +0.26] 1 Logs bounds checks dashboard
➖ dsd_uds_10mb_3k_timestamped_contexts_memory memory utilization +0.20 [-0.02, +0.42] 1 Logs
➖ quality_gate_security_idle memory utilization +0.02 [-0.02, +0.06] 1 Logs bounds checks dashboard
➖ quality_gate_idle memory utilization -0.09 [-0.13, -0.05] 1 Logs bounds checks dashboard
➖ python_openmetrics % cpu utilization -0.15 [-0.83, +0.54] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization -0.20 [-0.26, -0.14] 1 Logs bounds checks dashboard
➖ quality_gate_security_no_fs_load memory utilization -0.22 [-0.29, -0.15] 1 Logs bounds checks dashboard
➖ quality_gate_private_action_runner memory utilization -0.36 [-0.48, -0.24] 1 Logs bounds checks dashboard
➖ dsd_uds_client_drop_detector_cpu % cpu utilization -1.31 [-1.79, -0.83] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
✅ python_openmetrics checks_execution_time 10/10 77.60 ≤ 100 bounds checks dashboard
✅ python_openmetrics cpu_usage 10/10 1331.55 ≤ 1500 bounds checks dashboard
✅ python_openmetrics memory_usage 10/10 4.32GiB ≤ 4.75GiB bounds checks dashboard
✅ quality_gate_idle intake_connections 10/10 4 ≤ 5 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 173.45MiB ≤ 181MiB bounds checks dashboard
✅ quality_gate_idle total_bytes_received 10/10 747.82KiB ≤ 819.20KiB bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 2 ≤ 5 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 466.57MiB ≤ 542MiB bounds checks dashboard
✅ quality_gate_idle_all_features total_bytes_received 10/10 1.12MiB ≤ 1.25MiB bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 17 ≤ 40 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 212.12MiB ≤ 228MiB bounds checks dashboard
✅ quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
✅ quality_gate_logs total_bytes_received 10/10 263.41MiB ≤ 292MiB bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 385.82 ≤ 2000 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 19 ≤ 40 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 420.17MiB ≤ 455MiB bounds checks dashboard
✅ quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
✅ quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
✅ quality_gate_private_action_runner memory_usage 10/10 73.22MiB ≤ 75MiB bounds checks dashboard
✅ quality_gate_security_idle cpu_usage 10/10 29.46 ≤ 100 bounds checks dashboard
✅ quality_gate_security_idle memory_usage 10/10 330.40MiB ≤ 357MiB bounds checks dashboard
✅ quality_gate_security_mean_fs_load cpu_usage 10/10 62.36 ≤ 200 bounds checks dashboard
✅ quality_gate_security_mean_fs_load memory_usage 10/10 309.46MiB ≤ 337MiB bounds checks dashboard
✅ quality_gate_security_no_fs_load cpu_usage 10/10 22.44 ≤ 100 bounds checks dashboard
✅ quality_gate_security_no_fs_load memory_usage 10/10 311.46MiB ≤ 348MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 9ae3975 into main Sep 27, 2026
279 checks passed
@github-actions github-actions Bot added this to the 7.85.0 milestone Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants