Repository navigation
Conversation
|
✅ All CI checks and tests passed. Datadog automation helped this PR pass. 🎉 All green!🧪 All tests passed 🔄 Datadog retried 1 test - 1 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: ec29f24 | Docs | View more details | Give us feedback! |
Kotlin emits PermittedSubclasses for sealed classes when targeting JVM 17, so Mockito can no longer mock RumRawEvent and MobileRecord. Use real instances in tests instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
0xnm
force-pushed
the
nogorodnikov/rum-628/bump-jvm-bytecode-to-17
branch
from
October 16, 2026 13:47
5b6912f to
ec29f24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR bumps JVM bytecode generated to version 17.
Normally, the recent AGP build tooling should be able to process it.
The first AGP version which requires JDK 17 is 8.0, it was released 3 years ago https://developer.android.com/build/releases/agp-8-0-0-release-notes.
Building now needs JDK 17 / AGP 8, and customers with
jvmTargetbelow 17 can't inlinewithinSpanortransactionTraced(inline functions coming with SDK).Review checklist (to be filled by reviewers)