Repository navigation
Common coding conventions for the project - #3997
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🎉 All green!🧪 All tests passed 🔄 Datadog retried 2 tests - 2 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: 401e770 | Docs | View more details | Give us feedback! |
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
The stack-reconstruction workflow can commit reversals of newer upstream changes. Additional instruction errors can block PR creation and API preparation or leave intended reliability suites untested.
🤖 Bits Code Review · Commit 3d8acca
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d8accaff0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e32a9bcc86
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e32a9bc to
91cc7f3
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91cc7f3e73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
satween
added
the
ready-for-human-review
Run tool and build-logic tests and format before parallel checks in sdk-pr-prepare, default the stack base to develop, guard update against branches held by other worktrees, and include untracked files in reviews.
| Run: | ||
|
|
||
| ```bash | ||
| gt restack |
There was a problem hiding this comment.
why not using the gh stack instead ?
There was a problem hiding this comment.
I found graphite a bit more stable a the moment of writing this skill, maybe we could migrate to the gh stack later
There was a problem hiding this comment.
I am using gh stack with no problems and it is very well integrated in Github dashboard
| ### 3.3 Compile-check configuration | ||
|
|
||
| Detect build systems in the repo root (use `Glob`/`Read`): | ||
|
|
||
| | Manifest file | Default command | | ||
| |-----------------------|--------------------------| | ||
| | `package.json` | `npm run build` | | ||
| | `go.mod` | `go build ./...` | | ||
| | `Cargo.toml` | `cargo build` | | ||
| | `pom.xml` | `mvn -q compile` | | ||
| | `build.gradle(.kts)` | `./gradlew assembleLibrariesDebug` | | ||
| | `pyproject.toml` | `python -m compileall .` | | ||
| | (none, only `.py`) | `python -m compileall .` | |
There was a problem hiding this comment.
that seems redundant tbh, we don't have all this
|
|
||
| ## Naming convention | ||
|
|
||
| **Do not use `region` comments in tests.** |
4 participants
What does this PR do?
Adds shared skills for coding agents (sources in
ai/skills/, symlinked into.claude/skills/and.agents/skills/):/sdk-tests— unit test conventions./sdk-commit— commit message conventions./sdk-pr-prepare— checks before opening a PR: compile, tests, lint (Gradle tasks only), regeneration of checked-in generated files, then validation withcheckGeneratedFiles./sdk-pr-stack create|update— create and update stacked PRs with Graphite./sdk-review— code review focused on SDK-specific risks (binary compatibility, threading, main-thread blocking), run in parallel with the agent's built-in review.Updates
AGENTS.md:AtomicXXXfields asval.// When / Thenmarker.local_ci.sh: everything is available through Gradle tasks.Motivation
Help coding agents follow our project conventions consistently.
Additional Notes
All skill names start with
sdk-to:Review checklist (to be filled by reviewers)
🤖 Generated with Claude Code