Repository navigation
RUM-19113: Repair historical API link and OpenFeature code fence - #4014
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![datadog-prod-us1-5[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
The historical changelog link references the release 1.2.0 API surface, and the closing code fence restores the OpenFeature setup heading and anchor. The completed static review identified no actionable defects.
🤖 Bits Code Review · Commit 622c654
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: fb6883a | Docs | View more details | Give us feedback! |
0xnm
left a comment
0xnm
left a comment
There was a problem hiding this comment.
it seems it doesn't need to be stacked and can target develop as-is.
@0xnm yes, but prefer to merge them in order |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 622c6549b0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| * [OTHER] Analyse Benchmark reports in the CI | ||
| * [OTHER] Fix the flaky test in DataDogTimeProviderTest | ||
| * [OTHER] Generate a report on the SDK API changes ([dd-sdk-android/apiSurface](dd-sdk-android/apiSurface)) | ||
| * [OTHER] Generate a report on the SDK API changes ([dd-sdk-android/apiSurface](https://github.com/DataDog/dd-sdk-android/blob/f68d577ece9599dc4b1bf382688edf14cf20e9ef/dd-sdk-android/apiSurface)) |
There was a problem hiding this comment.
This commit is a documentation cleanup rather than a release preparation change, but it modifies CHANGELOG.md; repository policy reserves changelog updates exclusively for release preparation PRs. Revert this line here and apply the historical link correction during release preparation instead.
AGENTS.md reference: AGENTS.md:L257-L257
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in b6a402d. Removed the changelog edit from this PR and deferred the historical link correction to release preparation. The final diff is only the OpenFeature closing code fence. Foundation gate against the onboarding parent returns allow: OpenFeature finding resolved, no new findings or evaluation errors; the existing changelog finding remains.
There was a problem hiding this comment.
The user explicitly reaffirmed the historical-link correction after discussing this policy finding. Restored it as a narrow exception: only the URL in the existing 1.2.0 entry changes, pinned to that release commit (f68d577). The historical file exists in Git; later releases do not require updating this entry. The PR description now documents this decision for maintainer review. Foundation validation against the onboarding parent passes with both findings resolved; external URL availability is outside that gate’s coverage.
mariusc83
changed the title
mariusc83
changed the title
6b123d6 to
2b13514
Compare
The base branch was changed.
There was a problem hiding this comment.
More details
The static reviewer confirmed that the pinned historical API target exists and the OpenFeature code fence closes correctly. No actionable defects were reported across the supplied comparison, which also includes Foundation onboarding changes.
🤖 Bits Code Review · Commit 0204631
|
@DataDog please fix my ci |
|
I can only run on private repositories. |
0204631 to
fb6883a
Compare
0xnm
left a comment
0xnm
left a comment
There was a problem hiding this comment.
PR description and title should be updated, there is no OpenFeature part anymore.
What does this PR do?
Restores the release 1.2.0 API-surface link with an immutable historical GitHub URL and closes the dependency code fence in the OpenFeature README. The setup heading and its existing anchor now render as documentation.
Motivation
Resolve the two existing documentation findings identified by Foundation onboarding.
Additional Notes
Stacked on #4013; review and merge that PR first. This PR targets the onboarding branch so its diff contains only two documentation fixes. The historical changelog correction is an explicitly user-approved exception to the release-preparation-only guideline, reaffirmed after review. It repairs a broken link in the existing 1.2.0 entry without changing release wording. The target is pinned to that release commit and must not be updated for later releases. Maintainer review of this narrow exception remains welcome.
Ticket: https://datadoghq.atlassian.net/browse/RUM-19113
Validation: Foundation gate returned
allowagainst the onboarding parent, with both findings resolved, no remaining findings, and no evaluation errors. Staged whitespace checks passed; historical API file verified in commit f68d577 (release 1.2.0). No SDK code changes.Review checklist (to be filled by reviewers)