Repository navigation
(AAA) add new Data Access Control UI - #40738
OliviaShoup wants to merge 6 commits into
Conversation
![datadog-official[bot]](https://avatars.githubusercontent.com/in/1358509?s=60&v=4){kind=small}
There was a problem hiding this comment.
The preview fixture overrides the Governance Console’s published controls catalog with stub entries. The revised visibility instructions also stop before explaining how to complete or reverse the configuration.
🤖 Bits Code Review · Commit c15c9c0
| @@ -0,0 +1 @@ | |||
| {"Security":[{"name":"stub","description":"local preview stub","enforcement":[]}],"Cost Optimization":[{"name":"stub","description":"local preview stub","enforcement":[]}],"Data Hygiene":[{"name":"stub","description":"local preview stub","enforcement":[]}]} | |||
There was a problem hiding this comment.
Hugo mounts local data before vendored data, so this file overrides the Governance Console controls catalog supplied by websites-sources. The existing shortcode renders these arrays directly, replacing the available controls with three entries named stub and descriptions reading local preview stub. Remove the entire preview fixture file so the vendored catalog remains available.
React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it
What each reaction means
- 👍 Useful: correct, and you're fixing it or will.
- 👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
- 😕 Unclear: you can't tell what it means or why it matters.
- 👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.
🤖 Bits Code Review · Open Bits AI session
| 1. Under the heading for data not in Restricted Datasets (for example, {{< ui >}}Logs data not in Restricted Datasets{{< /ui >}}), select {{< ui >}}Unrestricted{{< /ui >}} or {{< ui >}}Restricted{{< /ui >}}. | ||
| 1. Click {{< ui >}}Save{{< /ui >}}. | ||
| 1. Navigate to [Access Control][7]. | ||
| 1. In the {{< ui >}}Data Hidden by Default{{< /ui >}} section, click {{< ui >}}Add New{{< /ui >}}. |
There was a problem hiding this comment.
The replacement procedure stops after opening the Add New dropdown. It removes the telemetry selection and save instructions, together with the procedure for returning a telemetry type to Unrestricted. Administrators no longer have complete instructions for enabling default-deny visibility or restoring access. Complete both directions using verified labels from the new UI.
React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it
What each reaction means
- 👍 Useful: correct, and you're fixing it or will.
- 👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
- 😕 Unclear: you can't tell what it means or why it matters.
- 👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.
🤖 Bits Code Review · Open Bits AI session
Committed With Claude
Committed With Claude
What does this PR do? What is the motivation?
Resolves DOCS-15824
Merge readiness
AI assistance
Used Claude to double-check for my own typos.
Additional notes
Holding for merge until GA during week of Oct 19.