chore(common, core): move cache and Supervisable into saluki-core

[tobz]

Summary

This PR moves Supervisable back to saluki-core, along with Cache and friends.

As part of reworking supervision to add support for "scopes," we want Supervisable back in saluki-core since we're getting rid of the idea that anything in the workspace can implement Supervisable. Instead, we're just going to go with the notion that nothing which can't otherwise depend on saluki-core can implement supervisable things.

As such, saluki-common becomes purely basic primitives that require no background tasks, asynchronicity, etc... while saluki-core and above hold those things. As such, saluki_common::cache now moves to saluki-core.

Change Type

• Bug fix
• New feature
• Non-functional (chore, refactoring, docs)
• Performance

How did you test this PR?

Existing tests.

References

DADP-2

[tobz]

• chore(agent-data-plane, config): hand back dynamic configuration tasks instead of spawning them #2712
• chore(common, core): move cache and Supervisable into saluki-core #2711 👈 (View in Graphite)
• chore(context, core): move saluki-context into saluki-core #2710
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[datadog-official]

More details

The relocation and dependency rewiring are internally consistent across workspace consumers, with no behavior change identified. Compile verification remained incomplete because the configured dependency source returned HTTP 502.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit fa5b4b5 · @DataDog review to ask questions}

[pr-commenter]

Binary Size Analysis (Agent Data Plane)

Baseline: 9e63899 · Comparison: 312aefa · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 38.48 MiB (baseline) vs 38.36 MiB (comparison)
Size Change: -126.29 KiB (-0.32%)

✅ Binary size difference within threshold

Changes by Module

Module	File Size	Symbols
saluki_context	-138.59 KiB	115
saluki_core::data_model::event	+88.69 KiB	146
core	-55.98 KiB	14931
saluki_core::data_model::tags	+41.06 KiB	37
saluki_core::topology::built	-32.07 KiB	35
saluki_core::cache::CacheBuilder<K,V,W,H>	+29.56 KiB	5
saluki_common::cache::CacheBuilder<K,V,W,H>	-29.51 KiB	5
saluki_core::topology::blueprint	+26.24 KiB	104
saluki_common::cache::expiry	-23.82 KiB	25
saluki_core::cache::expiry	+20.63 KiB	21
hashbrown	-20.33 KiB	1691
saluki_common::cache::Telemetry	-19.27 KiB	14
saluki_core::cache::Telemetry	+18.80 KiB	14
std	-17.19 KiB	667
anon.9d8942916f450a014c7f6e5d9773c016.267.llvm.2953199744583755391	-16.46 KiB	1
tokio	+16.42 KiB	3420
anon.6d71d9692aef30bf3c5a0484c5b493cc.267.llvm.7084973143883444914	+16.10 KiB	1
anon.9d8942916f450a014c7f6e5d9773c016.903.llvm.2953199744583755391	-14.81 KiB	1
anon.6d71d9692aef30bf3c5a0484c5b493cc.903.llvm.7084973143883444914	+14.62 KiB	1
anon.9d8942916f450a014c7f6e5d9773c016.901.llvm.2953199744583755391	-13.02 KiB	1

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW] +59.7Ki  [NEW] +59.5Ki    saluki_components::common::datadog::io::run_endpoint_io_loop::_{{closure}}::h15a965fc1b5a6f1e
  [NEW] +41.1Ki  [NEW] +41.0Ki    agent_data_plane::cli::run::create_topology::_{{closure}}::h4d4ce78c39724a5e
  [NEW] +37.9Ki  [NEW] +37.7Ki    _<saluki_components::forwarders::otlp::OtlpForwarder as saluki_core::components::forwarders::Forwarder>::run::_{{closure}}::h252ca254b106e4c3
  [NEW] +35.8Ki  [NEW] +35.7Ki    agent_data_plane::cli::run::handle_run_command::_{{closure}}::hdbb51c6c139576b0
  [NEW] +34.1Ki  [NEW] +34.0Ki    saluki_core::topology::blueprint::TopologyBuildState::build::_{{closure}}::h734355e2a3cc5202
  [NEW] +31.0Ki  [NEW] +30.9Ki    agent_data_plane::cli::dogstatsd::run_dogstatsd_command::_{{closure}}::h239751e8e3ee589e
  [NEW] +27.7Ki  [NEW] +27.6Ki    agent_data_plane::dogstatsd_contexts::artifact::for_each_record::hac22d8fcebd2295e
  [NEW] +27.5Ki  [NEW] +27.3Ki    _<saluki_components::transforms::aggregate::Aggregate as saluki_core::components::transforms::Transform>::run::_{{closure}}::ha5569e4fe676e480
  [NEW] +27.1Ki  [NEW] +26.9Ki    core::ptr::drop_in_place<agent_data_plane::cli::run::handle_run_command::{{closure}}>::h54ba656adcfbe5d4
  [NEW] +26.9Ki  [NEW] +26.7Ki    datadog_agent_commons::ipc::client::RemoteAgentClient::connect::_{{closure}}::_{{closure}}::_{{closure}}::h8369805a2ef60a21
  [DEL] -26.8Ki  [DEL] -26.6Ki    datadog_agent_commons::ipc::client::RemoteAgentClient::connect::_{{closure}}::_{{closure}}::_{{closure}}::h14020e74dbf13ac2
  [DEL] -27.1Ki  [DEL] -26.9Ki    core::ptr::drop_in_place<agent_data_plane::cli::run::handle_run_command::{{closure}}>::h26b26bfa6ecc4d8b
  [DEL] -27.5Ki  [DEL] -27.3Ki    _<saluki_components::transforms::aggregate::Aggregate as saluki_core::components::transforms::Transform>::run::_{{closure}}::h9e2eedcf1bab20f9
  [DEL] -27.6Ki  [DEL] -27.4Ki    saluki_core::topology::built::BuiltTopology::spawn_inner::_{{closure}}::hcecb1f0589b91693
  [DEL] -27.7Ki  [DEL] -27.6Ki    agent_data_plane::dogstatsd_contexts::artifact::for_each_record::h9053679a7c7c4282
  [DEL] -31.0Ki  [DEL] -30.9Ki    agent_data_plane::cli::dogstatsd::run_dogstatsd_command::_{{closure}}::hdb194efa2e919aa8
  [DEL] -35.8Ki  [DEL] -35.7Ki    agent_data_plane::cli::run::handle_run_command::_{{closure}}::h7a638dbf1937c3ba
  [DEL] -38.0Ki  [DEL] -37.8Ki    _<saluki_components::forwarders::otlp::OtlpForwarder as saluki_core::components::forwarders::Forwarder>::run::_{{closure}}::h154e0b8bdac85431
  [DEL] -41.1Ki  [DEL] -41.0Ki    agent_data_plane::cli::run::create_topology::_{{closure}}::ha4dcd0a8d8fb7e5d
  [DEL] -60.4Ki  [DEL] -60.2Ki    saluki_components::common::datadog::io::run_endpoint_io_loop::_{{closure}}::h4e117a76eb7fda79
  -0.6%  -132Ki  -0.6% -97.8Ki    [51148 Others]
  -0.3%  -126Ki  -0.3% -92.0Ki    TOTAL

[pr-commenter]

Regression Detector (Agent Data Plane)

Run ID: ffd5cb48-a37c-4e88-82f5-6e84b0b05638
Baseline: 9e638990 · Comparison: 312aefa5 · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (5)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment	goal	Δ mean %	links
quality_gates_rss_dsd_ultraheavy	memory	⚪ +1.74	metrics profiles logs
quality_gates_rss_dsd_heavy	memory	⚪ +0.46	metrics profiles logs
quality_gates_rss_dsd_medium	memory	⚪ -0.17	metrics profiles logs
quality_gates_rss_dsd_low	memory	⚪ -0.22	metrics profiles logs
quality_gates_rss_idle	memory	⚪ -0.54	metrics profiles logs

Bounds Checks: ✅ Passed (5)

experiment	check	replicates	observed	links
quality_gates_rss_dsd_heavy	memory_usage	10/10	✅ 231 MiB ≤ 250 MiB	metrics profiles logs
quality_gates_rss_dsd_low	memory_usage	10/10	✅ 51.3 MiB ≤ 60 MiB	metrics profiles logs
quality_gates_rss_dsd_medium	memory_usage	10/10	✅ 92.1 MiB ≤ 100 MiB	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory_usage	10/10	✅ 388 MiB ≤ 420 MiB	metrics profiles logs
quality_gates_rss_idle	memory_usage	10/10	✅ 33.5 MiB ≤ 40 MiB	metrics profiles logs

Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression. Experiments tagged (no analysis) show ⚠️ n/a: SMP ran them but produced no analysis, usually because a replicate failed and exhausted its retries. Check the SMP report for that experiment's replicate failures.