Repository navigation
Conversation
Binary Size Analysis (Agent Data Plane)Baseline: 216e499 · Comparison: f49a2a4 · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (5)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
bbbb8f0 to
7a9fd0d
Compare
b4ceeb7 to
9d18f9e
Compare
Add the APM_SEMANTIC_CORE_DD product decoder and let SemanticRegistryProvider subscribe through the Remote Configuration client. Export the provider for callers that build the trace pipeline. Each configuration replaces the whole registry. Select the last valid configuration in ascending ID order, warn about multiple assignments and report unsupported entries that were skipped during parsing. Log the selected registry once per accepted update rather than in each consumer. An empty assignment restores the embedded registry. Reject an assignment with no valid configuration so providers retain the last accepted registry. Errors reported to the Agent do not include payload contents. Test replacement, removal, invalid assignments and diagnostics through the decoder. Exercise the OTLP source and decoder builder paths to verify that their translators receive the configured provider. Startup subscription wiring is added separately.
There was a problem hiding this comment.
Human Summary
This PR adds the decoder for traces remote config semantic registry and wires it into the
SemanticRegistryProviderthat landed in the previous PR.AI Summary
#2718 gives OTLP trace translation and APM stats a
SemanticRegistryProvider. The provider can read a published registry or use the embedded default, but #2718 alone has no production subscription to publish remote registries. This PR supplies the missingAPM_SEMANTIC_CORE_DDproduct decoder and aSemanticRegistryProvider::subscribe(&client)entry point. It does not construct that subscription during ADP startup; #2724 does that.A registry JSON document describes one complete set of concept-to-attribute mappings, not a patch. #2718's parser handles one document. Here,
SemanticCoreDecoderimplements the RC client'sProductDecodercontract: it receives the set of configuration files currently assigned to this product, parses each file, selects a registry, and lets the RC client publish the selected snapshot to provider handles. No extra registry store or applier worker sits between the subscription and its readers.Change Type
How did you test this PR?
make fmt,cargo check --workspace,cargo check --workspace --tests,make check-docs,make check-clippyat the stack tip.saluki-componentstests: 549 passed at the stack tip.References