Auto-activate rust easy wins for feature-flagging-and-experimentation-sdk - #7041
Auto-activate rust easy wins for feature-flagging-and-experimentation-sdk#7041dd-octo-sts[bot] wants to merge 1 commit into
Conversation
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a4a7a08534
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tests/parametric/test_dynamic_configuration.py::TestDynamicConfigV2: missing_feature # Created by easy win activation script | ||
| tests/parametric/test_ffe/test_dynamic_evaluation.py::Test_Feature_Flag_Dynamic_Evaluation: missing_feature | ||
| tests/parametric/test_ffe/test_span_enrichment.py: missing_feature | ||
| tests/parametric/test_ffe/test_span_enrichment.py: '>=0.3.4-dev+c6880b8' # TODO: a lower version might be supported |
There was a problem hiding this comment.
With this file-level activation, Rust versions >=0.3.4-dev+c6880b8 now run every descendant not explicitly overridden; the added overrides skip all tracer-backed span-enrichment classes, leaving only Test_Span_Enrichment_Delta_Varint, which is a pure Python utility test with no test_library/Rust tracer interaction. That makes the Rust manifest report FFE span-enrichment coverage as passing without exercising the product behavior, so either keep the file skipped or add an explicit override for the delta-varint class until a tracer-backed class is enabled.
Useful? React with 👍 / 👎.
a4a7a08 to
2572c42
Compare
|
PRApprover will approve and merge this PR, FAQ, #dx-source-code-management 🛠️ PRApproval Status
➡️ Current phase: approved - manual merge required (this rule does not auto-merge) |
![dd-prapprover-prod-77c48c[bot]](https://avatars.githubusercontent.com/u/244837012?s=60&v=4){kind=small}
2572c42 to
4f2b24e
Compare
new commit added, dismiss all previous approvals
4f2b24e to
89f1245
Compare
new commit added, dismiss all previous approvals
89f1245 to
0277d71
Compare
new commit added, dismiss all previous approvals
…tation-sdk Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
0277d71 to
87dc9b5
Compare
new commit added, dismiss all previous approvals
Automated activation of easy-win tests for
rustowned byfeature-flagging-and-experimentation-sdkView nightly workflow run