Auto-activate python easy wins for asm-libraries - #7164
Conversation
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 09b0f520b3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tests/appsec/api_security/test_endpoints.py::Test_LLM_Endpoint::test_root_has_no_llm_tags: # Easy win for flask-poc and version 4.10.4 | ||
| - weblog_declaration: | ||
| "*": irrelevant (openai instrumentation is framework-independent, only tested on flask-poc) | ||
| flask-poc: v4.12.0rc1 |
There was a problem hiding this comment.
For the flask-poc 4.10.4 easy-win case, this change only adds a comment; the actual manifest value below still requires flask-poc: v4.12.0rc1, so Python flask-poc runs on 4.10.4 through pre-4.12 remain classified as not yet enabled. If the goal is to auto-activate the easy win called out here, the manifest version needs to be lowered rather than just documented in a YAML comment.
Useful? React with 👍 / 👎.
09b0f52 to
25cae35
Compare
|
PRApprover will approve and merge this PR, FAQ, #dx-source-code-management 🛠️ PRApproval Status
➡️ Current phase: approved - manual merge required (this rule does not auto-merge) |
![dd-prapprover-prod-77c48c[bot]](https://avatars.githubusercontent.com/u/244837012?s=60&v=4){kind=small}
25cae35 to
2aae51c
Compare
new commit added, dismiss all previous approvals
2aae51c to
314000b
Compare
new commit added, dismiss all previous approvals
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
314000b to
c360712
Compare
new commit added, dismiss all previous approvals
Automated activation of easy-win tests for
pythonowned byasm-librariesView nightly workflow run