Skip to content

test(dotnet): enable ot.th/ot.rv tracestate sampling scenarios [dotnet@milan.garnier/ot.th] - #7438

Open
MilanGarnier wants to merge 26 commits into
mainfrom
milan.garnier/enable-otel-th-rv-dotnet-manifest
Open

test(dotnet): enable ot.th/ot.rv tracestate sampling scenarios [dotnet@milan.garnier/ot.th] #7438
MilanGarnier wants to merge 26 commits into
mainfrom
milan.garnier/enable-otel-th-rv-dotnet-manifest

Conversation

@MilanGarnier

@MilanGarnier MilanGarnier commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Enables tests/test_otel_tracestate_sampling.py entries in manifests/dotnet.yml from missing_feature (APMAPI-2171) to v3.51.0, matching dd-trace-dotnet's implementation on milan.garnier/ot.th:

  • emit ot= on a fresh probability decision (A1, all 5 rates)
  • forward inbound ot= unchanged, kept or dropped (A2/A2c)
  • th-only never fabricates rv, kept or dropped (A2b/A2d)
  • preserve dd= and unrelated vendors (A3)
  • force-keep (Manual/ASM) erases th but forwards inherited rv (A4)
  • sampled-without-ot never fabricates ot= (A5)
  • malformed ot= is cleared, not re-derived (A6)
  • 64-bit to 56-bit rv/th precision-boundary clamping (A7)

Draft until dd-trace-dotnet#milan.garnier/ot.th merges.

genesor and others added 25 commits July 23, 2026 11:12
Stacked on #7372 (the ot.th/ot.rv conformance scaffolding). Flips the
Rust entries in manifests/rust.yml from missing_feature to
'>=0.5.0-dev' and backfills the 3 previously-unlisted classes
(Test_ForwardInboundOtUnchangedWhenDropped, Test_ThOnlyDoesNotFabricateRv,
Test_ThOnlyDoesNotFabricateRvWhenDropped) as missing_feature across the
other 8 manifests to keep the "disabled for every tracer" invariant
intact until each ships. OTLP entries (APMAPI-2172) are left untouched.
…estate-sampling-scaffolding

# Conflicts:
#	manifests/rust.yml
Stacked on #7372 (ot.th/ot.rv conformance scaffolding). Flips all 15
dotnet entries in manifests/dotnet.yml from missing_feature to
v3.51.0: dd-trace-dotnet implements emit-on-probability-decision,
forward-unchanged (kept/dropped), th-only no-fabrication
(kept/dropped), dd=/vendor preservation, force-keep th erasure with rv
forwarding, malformed-ot clearing, and 64-to-56-bit rv/th boundary
clamping.
@MilanGarnier MilanGarnier changed the title [dotnet@milan.garnier/ot.th] Enable ot.th/ot.rv tracestate sampling scenarios feat(dotnet): enable ot.th/ot.rv tracestate sampling scenarios [dotnet@milan.garnier/ot.th] Aug 3, 2026
@MilanGarnier
MilanGarnier changed the base branch from main to milan.garnier/feat-rs-ot.th August 3, 2026 16:19
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Aug 3, 2026

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

🚦 3 Pipeline jobs failed

Testing the test | Fail if target branch is specified   View in Datadog   GitHub Actions

See error This PR can't be merged due to the title specifying a target branch.

Testing the test | System Tests (dotnet, dev) / Get parameters / Get parameters   View in Datadog   GitHub Actions

See error Error response from daemon: manifest unknown

Testing the test | all-jobs-are-green   View in Datadog   GitHub Actions

See error Some CI checks or statuses failed during initial check for target branch and system tests.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1b7ce7b | Docs | Datadog PR Page | Give us feedback!

@MilanGarnier MilanGarnier changed the title feat(dotnet): enable ot.th/ot.rv tracestate sampling scenarios [dotnet@milan.garnier/ot.th] test(dotnet): enable ot.th/ot.rv tracestate sampling scenarios [dotnet@milan.garnier/ot.th] Aug 4, 2026
@MilanGarnier
MilanGarnier changed the base branch from milan.garnier/feat-rs-ot.th to main August 4, 2026 09:45
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet

@MilanGarnier
MilanGarnier marked this pull request as ready for review August 4, 2026 09:47
@MilanGarnier
MilanGarnier requested review from a team as code owners August 4, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants