Auto-activate python easy wins for apm-sdk-capabilities - #7440
Auto-activate python easy wins for apm-sdk-capabilities#7440dd-octo-sts[bot] wants to merge 1 commit into
Conversation
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
PRApprover will approve and merge this PR, FAQ, #dx-source-code-management 🛠️ PRApproval Status
➡️ Current phase: waiting to merge... |
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 541b33f474
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tests/otel/test_tracing_otlp.py::Test_Otlp_Forwards_Inherited_Ot: missing_feature (APMAPI-2172) | ||
| tests/otel/test_tracing_otlp.py::Test_Otlp_Forwards_Inherited_Ot: # TODO: a lower version might be supported | ||
| - declaration: missing_feature (APMAPI-2172) | ||
| component_version: <4.12.2 |
There was a problem hiding this comment.
These newly added activation conditions leave the <4.12.2 range unquoted. The manifest review rules require values containing special YAML characters like </> to be quoted, so these should be written as '<4.12.2' (and likewise for the other newly added component_version ranges below) to keep the manifest compliant with the repo's YAML conventions. .cursor/rules/pr-review.mdcL61-L65
Useful? React with 👍 / 👎.
🎉 All green!🧪 All tests passed 🔄 Datadog auto-retried 1 job - 1 passed on retry 🔗 Commit SHA: 541b33f | Docs | Datadog PR Page | Give us feedback! |
![dd-prapprover-prod-77c48c[bot]](https://avatars.githubusercontent.com/u/244837012?s=60&v=4){kind=small}
nccatoni
left a comment
nccatoni
left a comment
There was a problem hiding this comment.
Just to stop the auto merge
1 participant
Automated activation of easy-win tests for
pythonowned byapm-sdk-capabilitiesView nightly workflow run