add IAST code injection tests for java - #7445
Open
claponcet wants to merge 5 commits into
Open
Conversation
Contributor
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 89915c1 | Docs | Datadog PR Page | Give us feedback! |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2dac0de616
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
nccatoni
reviewed
Aug 7, 2026
nccatoni
left a comment
Collaborator
There was a problem hiding this comment.
LGTM (for @DataDog/system-tests-core) but you should get a review from someone more familiar with the feature and the tracer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The IAST
CODE_INJECTIONsink was not covered by system-tests for the Java tracer. This adds the weblog endpoints and enables the existingtest_code_injection.pytests so the Java library's code-injection detection (BeanShell sink) is validated end-to-end.Changes
CodeInjectionExampleshelper iniast-commonthat triggers the sink by evaluating input through BeanShell (bsh.Interpreter.eval), with an insecure (tainted input) and secure (hardcoded literal) variant.POST /iast/code_injection/test_insecureandPOST /iast/code_injection/test_securein the weblogs that carry the full IAST sink surface:akka-http,jersey-grizzly2,resteasy-netty3,spring-boot,vertx3,vertx4.bshdependency toiast-common(optional) and to each weblog that implements the endpoint.TestCodeInjectionandTestCodeInjection_StackTraceinmanifests/java.ymlfromv1.65.0-SNAPSHOT:play/ratpack:incomplete_test_app (endpoint not implemented)— these weblogs do not implement the IAST sink endpoints.spring-boot-3-native:irrelevant (GraalVM. Tracing support only).Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present