Auto-activate php easy wins for apm-sdk-capabilities - #7461
Auto-activate php easy wins for apm-sdk-capabilities#7461dd-octo-sts[bot] wants to merge 1 commit into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
PRApprover will approve and merge this PR, FAQ, #dx-source-code-management 🛠️ PRApproval Status
➡️ Current phase: CI tests failed. Please fix the failing tests and rerun the workflow, click Workflow Link -> Workflow Starter Link -> Start Workflow |
|
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dfb3a8e2db
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| weblog: [apache-mod-7.1-zts, apache-mod-7.0, apache-mod-7.4-zts, apache-mod-8.0-zts, apache-mod-7.2, php-fpm-7.2, apache-mod-8.1-zts, apache-mod-7.0-zts, php-fpm-8.0, apache-mod-8.2, php-fpm-8.2, php-fpm-7.0, apache-mod-7.1, symfony7x, apache-mod-8.2-zts, php-fpm-7.4, apache-mod-7.2-zts, php-fpm-7.3, apache-mod-7.3, apache-mod-7.4, laravel11x, apache-mod-7.3-zts, php-fpm-8.1, php-fpm-8.5, apache-mod-8.0, apache-mod-8.1, php-fpm-7.1] | ||
| - declaration: incomplete_test_app (/make_distant_call endpoint is not correctly implemented) | ||
| excluded_weblog: [apache-mod-7.1-zts, apache-mod-7.0, apache-mod-7.4-zts, apache-mod-8.0-zts, apache-mod-7.2, php-fpm-7.2, apache-mod-8.1-zts, apache-mod-7.0-zts, php-fpm-8.0, apache-mod-8.2, php-fpm-8.2, php-fpm-7.0, apache-mod-7.1, symfony7x, apache-mod-8.2-zts, php-fpm-7.4, apache-mod-7.2-zts, php-fpm-7.3, apache-mod-7.3, apache-mod-7.4, laravel11x, apache-mod-7.3-zts, php-fpm-8.1, php-fpm-8.5, apache-mod-8.0, apache-mod-8.1, php-fpm-7.1] | ||
| tests/test_baggage.py::Test_Baggage_Headers_Malformed: # TODO: a lower version might be supported |
There was a problem hiding this comment.
This parsed manifest key is alphabetically before the preceding Test_Baggage_Headers_Malformed2 key, so utils/manifest/_internal/validate.py::assert_key_order reports the PHP manifest as unsorted and manifest validation fails until Malformed is moved above Malformed2. .cursor/rules/pr-review.mdcL61-L65
Useful? React with 👍 / 👎.
| - declaration: missing_feature | ||
| - weblog_declaration: | ||
| symfony7x: missing_feature (OTel SDK requires PHP >= 8.1) |
There was a problem hiding this comment.
For PHP 1.23.3 on symfony7x, this new method entry still adds an unconditional missing_feature and then explicitly marks symfony7x as missing_feature; combined with the class-level rule above that still omits symfony7x from excluded_weblog, the advertised easy win remains deselected even though utils/build/docker/php/symfony7x.Dockerfile builds PHP 8.2. Remove the unconditional skip and allow symfony7x through the class/method rules so the test can actually run for that variant.
Useful? React with 👍 / 👎.
86cf5b9 to
3816eb6
Compare
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
3816eb6 to
268ef00
Compare
Automated activation of easy-win tests for
phpowned byapm-sdk-capabilitiesView nightly workflow run