Ew auto merge per team lang - #7475
Conversation
|
|
4dc0988 to
0632f86
Compare
0632f86 to
b43ec50
Compare
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 37190a8 | Docs | Datadog PR Page | Give us feedback! |
f78de80 to
37190a8
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37190a89b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @scenarios.test_the_test | ||
| class Test_GithubNightly: |
There was a problem hiding this comment.
Add the required feature decorator
This new test class has a scenario decorator but no feature association. Repository rules require every test class to use either a specific @features.* decorator or @features.not_reported; without one, these tests lack the expected feature ownership/reporting metadata.
AGENTS.md reference: AGENTS.md:L9-L19
Useful? React with 👍 / 👎.
| sys.executable, | ||
| "-m", | ||
| "utils.scripts.activate_easy_wins", | ||
| "--no-download", |
There was a problem hiding this comment.
Pass the selected reports directory to activation
When a caller supplies any --reports-dir other than data, reports are extracted there, but the spawned activate_easy_wins --no-download command still reads its hard-coded Path("data/"). Such invocations therefore fail when data is absent or, worse, activate from stale data; either propagate this option to the activation command or arrange for it to read the selected directory.
Useful? React with 👍 / 👎.
| if pr_number is None: | ||
| _create_pr(branch_name, owner, library, options.github, runner) | ||
| pr_number = _find_pr_number(branch_name, runner) | ||
| if pr_number is None: | ||
| raise RuntimeError(f"Could not find PR after creating it for {branch_name}") | ||
| _run_checked(["gh", "pr", "ready", pr_number], runner) |
There was a problem hiding this comment.
Recover existing draft activation PRs
If a run creates the draft PR and is cancelled or fails before the subsequent gh pr ready, the next nightly run finds an existing PR and permanently skips the only ready transition because it is inside this pr_number is None block. The local gh pr ready --help explicitly describes the command as marking a pull request ready for review, so this stranded PR remains draft indefinitely and an opted-in pair also cannot enable auto-merge; ensure eligible existing draft PRs are marked ready as well.
Useful? React with 👍 / 👎.
Motivation
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present