Skip to content

Ew auto merge per team lang - #7475

Open
nccatoni wants to merge 2 commits into
mainfrom
nccatoni/ew-auto-merge-per-team-lang
Open

Ew auto merge per team lang#7475
nccatoni wants to merge 2 commits into
mainfrom
nccatoni/ew-auto-merge-per-team-lang

Conversation

@nccatoni

@nccatoni nccatoni commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/test_the_test/test_github_nightly.py                              @DataDog/system-tests-core
utils/ci/github/__init__.py                                             @DataDog/system-tests-core
utils/ci/github/nightly.py                                              @DataDog/system-tests-core
.github/workflows/nightly.yml                                           @DataDog/system-tests-core
utils/scripts/libraries_and_scenarios_rules.yml                         @DataDog/system-tests-core

@nccatoni
nccatoni force-pushed the nccatoni/ew-auto-merge-per-team-lang branch 3 times, most recently from 4dc0988 to 0632f86 Compare August 7, 2026 11:47
@nccatoni
nccatoni force-pushed the nccatoni/ew-auto-merge-per-team-lang branch from 0632f86 to b43ec50 Compare August 7, 2026 11:47
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Aug 7, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 37190a8 | Docs | Datadog PR Page | Give us feedback!

@nccatoni
nccatoni force-pushed the nccatoni/ew-auto-merge-per-team-lang branch from f78de80 to 37190a8 Compare August 7, 2026 12:21
@nccatoni
nccatoni marked this pull request as ready for review August 7, 2026 12:25
@nccatoni
nccatoni requested a review from a team as a code owner August 7, 2026 12:25

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 37190a89b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +69 to +70
@scenarios.test_the_test
class Test_GithubNightly:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required feature decorator

This new test class has a scenario decorator but no feature association. Repository rules require every test class to use either a specific @features.* decorator or @features.not_reported; without one, these tests lack the expected feature ownership/reporting metadata.

AGENTS.md reference: AGENTS.md:L9-L19

Useful? React with 👍 / 👎.

sys.executable,
"-m",
"utils.scripts.activate_easy_wins",
"--no-download",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Pass the selected reports directory to activation

When a caller supplies any --reports-dir other than data, reports are extracted there, but the spawned activate_easy_wins --no-download command still reads its hard-coded Path("data/"). Such invocations therefore fail when data is absent or, worse, activate from stale data; either propagate this option to the activation command or arrange for it to read the selected directory.

Useful? React with 👍 / 👎.

Comment on lines +242 to +247
if pr_number is None:
_create_pr(branch_name, owner, library, options.github, runner)
pr_number = _find_pr_number(branch_name, runner)
if pr_number is None:
raise RuntimeError(f"Could not find PR after creating it for {branch_name}")
_run_checked(["gh", "pr", "ready", pr_number], runner)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Recover existing draft activation PRs

If a run creates the draft PR and is cancelled or fails before the subsequent gh pr ready, the next nightly run finds an existing PR and permanently skips the only ready transition because it is inside this pr_number is None block. The local gh pr ready --help explicitly describes the command as marking a pull request ready for review, so this stranded PR remains draft indefinitely and an opted-in pair also cannot enable auto-merge; ensure eligible existing draft PRs are marked ready as well.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant