Refactor dataset location handling and enhance caching mechanisms - #135
Merged
Merged
Conversation
- Updated `DatasetLocation` methods to improve dataset preview and navigation functionality, including the introduction of a new `list_nav_children` method. - Enhanced the `list_dataset_preview` method to accept a dataset kind parameter, streamlining the preview retrieval process. - Introduced `discover_cached_candidates` and `discover_cached_candidate_at` functions to optimize candidate discovery from cached sources. - Updated `CatalogSnapshot` methods to support cached file discovery, improving performance during catalog operations. - Enhanced request logging with metrics tracking for better performance insights in the CLI server. - Improved UI caching mechanisms to retain successful summaries and manage background refreshes effectively. This commit aims to enhance the overall efficiency and user experience of dataset handling and querying in the application.
- Updated the `storage.rs` file to replace references from `chronicle_manifest` to `catalog::manifest`, improving modularity and clarity. - Introduced a new `PersistentCache` module to manage key/value caching, enhancing performance and data retrieval efficiency. - Added `DatasetLocation` and `DatasetResolver` structures to streamline dataset handling and improve location management. - Enhanced the `CompactJsonlStore` to utilize the new manifest handling methods, ensuring consistency across data operations. - Introduced new methods for managing dataset locations and improved error handling in manifest loading. This commit aims to improve the overall architecture and performance of the data storage and catalog management systems.
…ce caching capabilities. This change allows for better management of key/value caching within the storage module, improving performance and data retrieval efficiency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DatasetLocationmethods to improve dataset preview and navigation functionality, including the introduction of a newlist_nav_childrenmethod.list_dataset_previewmethod to accept a dataset kind parameter, streamlining the preview retrieval process.discover_cached_candidatesanddiscover_cached_candidate_atfunctions to optimize candidate discovery from cached sources.CatalogSnapshotmethods to support cached file discovery, improving performance during catalog operations.This commit aims to enhance the overall efficiency and user experience of dataset handling and querying in the application.