server list ping determination bug fix#2831
Open
MC-Samuel wants to merge 4 commits into
Open
Conversation
tal5
requested changes
Jul 22, 2026
| } | ||
| return false; | ||
| }); | ||
| event.setNumPlayers(event.getNumPlayers() - counter.intValue()); |
Member
There was a problem hiding this comment.
This looks good, but missing one check:
If a plugin modified the player count to something else already we don't want to mess with that, so should start by checking if NumPlayers is the same as listed.size(), and only decrease NumPlayers if it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the number of players on the server wouldn't update when changed with the
EXCLUDE_PLAYERSdetermination.Reported at https://discord.com/channels/315163488085475337/1522089160108675073