Fix metadata query leaks, scoped gather, and timeouts - #10
Open
saif-ellafi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has been AI generated following a heavy debugging session on certain slowness.
Feedback is welcome.
Summary
gathertake an optional path prefix and timeout so callers can scan a subdirectory and fail instead of hanging.%Kargument) and keep liveonUpdatestreams running until cancel/timeout.Test plan
gatherwith no prefix still returns the full container listinggather(relativePathPrefix: …)only returns files under that prefixgather(timeout: …)fails cleanly when metadata never finishesonUpdate, updates keep arriving until the event channel is cancelled