Skip to content

fix(lint): disable the zizmor self-repository audit in a shared config - #591

Merged
DevSecNinja merged 1 commit into
mainfrom
steward/zizmor-shared-config
Nov 18, 2026
Merged

DevSecNinja merged 1 commit into
mainfrom
steward/zizmor-shared-config

Conversation

@DevSecNinja

Copy link
Copy Markdown
Owner

Description

zizmor 1.30 added the self-repository audit. It fails Lint on gating repos (DevSecNinja/home-assistant-win-companion#325) and opened code-scanning alerts #27 to #31 here. We pick $/ or ./ per workflow on purpose ($/ in lint-include.yml to call lint.yml at its own commit, #552; ./ in callers), so the owner decided to disable the audit centrally (repo-steward T152 a). There was no shared zizmor config yet; this adds one that ships with lint.yml.

Closes #590

Changes

  • scripts/lint/zizmor.yml: shared config that disables self-repository, with the reason.
  • scripts/lint/zizmor.sh: passes it with --config unless the repository has its own .github/zizmor.yml, .github/zizmor.yaml, zizmor.yml or zizmor.yaml. zizmor loads one config only, so a repository config keeps working and replaces the shared one. Today that's DevSecNinja/devsecninja-com, which would need the rule in its own zizmor.yml if it hits the audit.
  • tests/lint-scripts.sh: covers the shared config in both SARIF modes and a repository's own config.
  • docs/architecture.md: documents the shared config (after v4.7.0).

Callers pick this up with their next lint.yml pin bump (Renovate). Open PR #584 also edits tests/lint-scripts.sh but in a different hunk; no open PR touches a zizmor config, so this isn't stacked.

Checklist

  • Linting passes locally (mise exec -- lefthook run pre-commit): not run. repo-steward works API-only without a clone. zizmor.sh was smoke-tested in bash with a stub mise (shared config with and without SARIF, a repository config, exit code on failure); tests/lint-scripts.sh runs in CI.
  • Commit messages follow Conventional Commits (signed commit via steward commit-files)
  • Documentation updated (if applicable)

zizmor 1.30 added the self-repository audit, which asks to rewrite every
workspace-relative `uses: ./...` as `uses: $/...`. We pick the form per
workflow instead: `$/` where a reusable workflow must call a sibling at its
own commit (lint-include.yml calling lint.yml, #552) and `./` in callers. The
audit fails lint on gating repos (home-assistant-win-companion#325) and adds
code-scanning alerts here.

- scripts/lint/zizmor.yml: shared config that disables self-repository, with
  the reason. It ships with lint.yml at the caller's pinned commit.
- scripts/lint/zizmor.sh: pass it with --config unless the repo has its own
  .github/zizmor.yml or zizmor.yml (zizmor loads one config only).
- tests/lint-scripts.sh: cover both cases.
- docs/architecture.md: document the shared config.
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bd60da04-165e-4b49-9f4b-50e0cc166d74
Commits

Reviewing files that changed from the base of the PR and between 76258ab and 45dfa1c.

Files selected for processing: 4

  • docs/architecture.md
  • scripts/lint/zizmor.sh
  • scripts/lint/zizmor.yml
  • tests/lint-scripts.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The shared zizmor configuration change has no active review issues.

No open issues 🎉

What changed in this PR

Adds a shared zizmor configuration to the reusable lint workflow, disabling the self-repository audit while preserving repository-specific configuration.

Changes:

  • Disables the audit centrally and documents the intentional use of both $/ and ./ workflow references.
  • Applies the shared config only when no repository config exists.
  • Adds argument checks for both SARIF modes and repository-config overrides.
File Description
tests/​lint-scripts.sh Covers shared-config arguments and repository overrides.
scripts/​lint/​zizmor.yml Disables self-repository with an explanatory comment.
scripts/​lint/​zizmor.sh Selects the shared config unless a repository config exists.
docs/​architecture.md Documents config precedence and the disabled audit.

Review effort: Balanced

@DevSecNinja

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@DevSecNinja
DevSecNinja merged commit 04e9b95 into main Nov 18, 2026
48 checks passed
@DevSecNinja
DevSecNinja deleted the steward/zizmor-shared-config branch November 18, 2026 16:49
DevSecNinja added a commit that referenced this pull request Nov 18, 2026
…ing main

docs/architecture.md takes main's version for now, so merging main is clean;
the next commit after the merge restores the line-endings section next to
#591's zizmor-config section. tests/lint-scripts.sh is the clean three-way
merge of both.
Refs #580

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
DevSecNinja added a commit that referenced this pull request Nov 18, 2026
Puts the line-endings linter section back in docs/architecture.md, next
to the zizmor-config section that #591 added at the same place.
Refs #580

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zizmor self-repository audit fails lint on ./ uses: references

2 participants