Skip to content

feat: SkillSpector report on every AI primitive change #211

Open
3 of 3 issues completed
Open

Description

@DevSecNinja

Problem

The owner wants an NVIDIA SkillSpector report on every change to external (and authored) AI primitives. #125 (September) adds fail-closed SkillSpector scans, but:

  • its own Scan AI primitives job fails
  • it's about 1,160 lines, well over the reviewable-PR guideline (~200-400, at most ~800)
  • it doesn't post a report on the PRs where external text changes: the review PRs from the materialize gate (fix: restore the review gate for external APM primitives #210) and the Renovate github/awesome-copilot bumps

Proposed solution

  • Rescue ci(security): add fail-closed SkillSpector scans #125 as two PRs, each with its own sub-issue:
    1. the scanner script and its tests
    2. the workflow, smoke cases and docs
  • Fix the failing scan job (diagnose run 35013183566).
  • Run on PRs that change �pm.yml, �pm.lock.yaml, .github/agents/, .github/prompts/, .apm/, .agents/ or hooks, including materialize PRs.
  • Post a SkillSpector summary as a PR comment (findings by severity, file/line links), as well as SARIF to Code Scanning. Update the comment in place on re-runs.
  • Make it a required status check for those paths. Keep it fail-closed on HIGH/CRITICAL findings and on scanner errors.
  • Close ci(security): add fail-closed SkillSpector scans #125 once its content has landed through the split PRs.

Alternatives considered

Merging #125 as-is. It's too large to review properly, and it doesn't produce the report on the PRs that matter.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions