Skip to content

fix(ci): generate-index can't push unsigned commits to the protected main branch #239

Open

Description

@DevSecNinja

Problem

generate-index.yml on main still pushes an unsigned [skip ci] commit straight to main with GITHUB_TOKEN whenever the index is stale on push. #221 moved the check onto PRs, but the push-on-main fallback remains. Since 2026-11-15, ai-toolkit's steward-default-branch ruleset requires signed commits and linear history. Only the repository admin role can bypass it, and GITHUB_TOKEN/github-actions[bot] doesn't have that role. The next time the index is stale on main, the push will be rejected and the job will fail. The last run skipped the push step, so this is latent. Found in the 2026-11-15 merged-PR review.

Proposed solution

Pick one (simplest first):

Add a test or actionlint/zizmor check that no workflow pushes to the default branch with GITHUB_TOKEN.

Alternatives considered

Adding a ruleset bypass for github-actions: it weakens the signed-commit rule for every workflow.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions