Skip to content

refactor(skillspector): report findings as checks only, drop the PR comment #250

Closed

Description

@DevSecNinja

SkillSpector (#211) currently reports a PR's findings three times:

  1. The Scan AI primitives job fails on the severity gate. Accepted findings live in the repo and are reviewed by PR.
  2. Code Scanning: the SARIF upload (category: skillspector/static) creates the GitHub Advanced Security "SkillSpector" check, with inline annotations on changed lines. Example: feat(skills): vendor SHA-pinned Humanizer #249.
  3. A sticky PR comment (<!-- skillspector-report -->) by github-actions[bot] repeats the full report.

The owner's preference: findings should show up as checks, not also as a comment.

  • Remove the comment job, including the stale-comment "clear" path, and any comment-only script code and tests. Keep the step summary ($GITHUB_STEP_SUMMARY) and the reports artifact.
  • Make sure the gate and the Code Scanning check agree. A finding accepted in the repo must not still fail the "SkillSpector" check. For example, leave accepted findings out of the SARIF, or mark them suppressed. If they already agree, say so in the PR.
  • Update the docs that mention the PR comment.

Done when a PR that changes AI primitives gets the checks plus the run summary, and no comment.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions