Repository navigation
ci: migrate .github callers to v3.7.1 (App credentials, gitleaks fix) - #259
Merged
Merged
Conversation
Part of DevSecNinja/repo-steward#73 (batch 3, the gitleaks wave). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 53 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block approval of the workflow updates.
No open issues 🎉
What changed in this PR
Updates the toolkit’s Config Sync and Release Please callers to the shared v3.7.1 workflows, enabling Automation App authentication and preparing for delivery of the central gitleaks configuration fix.
Changes:
- Pins both reusable workflows to the v3.7.1 commit.
- Passes
AUTOMATION_APP_PRIVATE_KEYexplicitly and removes Release Please’s legacy App inputs. - Leaves permissions and the out-of-scope APM materialization workflow unchanged.
| File | Description |
|---|---|
.github/workflows/release-please.yml |
Updates the workflow pin and switches to the Automation App secret. |
.github/workflows/config-sync.yml |
Updates the workflow pin and forwards the App secret for App-authored sync PRs. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #258
Changes
.github/workflows/config-sync.yml: pinconfig-sync.ymlv1.9.0 → v3.7.1 (e28a49a14d4530962b165e0d35a8a331b2b42f23) and passAUTOMATION_APP_PRIVATE_KEYby name, so the sync PR is opened by the DevSecNinja Automation App (App-opened PRs run CI). The next sync delivers the fixed.gitleaks.toml([extend] useDefault = true, so gitleaks keeps its default rules and only adds the allowlist)..github/workflows/release-please.yml: pinrelease-please.ymlv1.9.0 → v3.7.1 (e28a49a14d4530962b165e0d35a8a331b2b42f23), drop the legacyapp-id: ${{ vars.RELEASE_PLEASE_APP_ID }}input and replaceapp-private-keywithAUTOMATION_APP_PRIVATE_KEY: ${{ secrets.AUTOMATION_APP_PRIVATE_KEY }}. Outputs are unchanged.Only the config-sync and release-please callers change.
apm-materialize.ymlstill readsRELEASE_PLEASE_APP_*directly and is out of scope here, so the legacy credentials stay until it moves. Renovate #130 also bumps other workflows and stays open.Permissions:
contents: writeandpull-requests: writecover v3.7.1; nothing is added. On public repositories the credentials live in theproductionenvironment (pinned tomain); the reusable job declares it withdeployment: false.Post-merge check
main: green, credentials validated, release PR bydevsecninja-automation[bot].main: green with no "falls back to GITHUB_TOKEN" warning; the sync PR (by the App) carries the fixed.gitleaks.toml.Part of DevSecNinja/repo-steward#73 (batch 3, owner-approved). Opened by repo-steward through the GitHub API; the commit is signed by GitHub (
createCommitOnBranch).