Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions .apm/instructions/devsecninja-conventions.instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,14 @@ API-only commits use the GitHub-signed path under "Signed commits".
- Use `feat!:` / `fix!:` (or a `BREAKING CHANGE:` footer) for breaking changes.
A new required input to a centralized/reusable workflow IS breaking, so
Renovate does not automerge a change that breaks downstream CI.
- For execution-authorized work, run lint and tests before opening a PR and fix anything that fails:
`mise exec -- lefthook run pre-commit` plus the repo's test command. Never open
a PR with known-failing checks. For static-only work, disclose skipped runtime
- For execution-authorized work, run lint and tests before opening a PR and fix
anything that fails. If the repo configures Lefthook (a Lefthook config such
as `lefthook.yml` or `.lefthook.toml`), run
`mise exec -- lefthook run pre-commit` plus the repo's test command. Otherwise
run the lint, hook and test commands the repo documents (for example in
`CONTRIBUTING.md` or its `.github/copilot-instructions.md`); don't add or
install Lefthook just to satisfy this rule. Never open a PR with
known-failing checks. For static-only work, disclose skipped runtime
checks instead of claiming they passed, and do not open a PR if doing so
would trigger unauthorized workflows.
- Update documentation in the same PR as the code it describes — READMEs, inline
Expand Down Expand Up @@ -122,9 +127,11 @@ and prefer reuse over duplication.
## Tooling and files

- Tools are managed by [mise](https://mise.jdx.dev/) (`.mise.toml`); run them via
`mise exec -- <tool>` only within the authorized execution scope. Run
`mise exec -- lefthook run pre-commit` before committing when authorized;
otherwise stop before any commit that would run unapproved hooks or filters.
`mise exec -- <tool>` only within the authorized execution scope. When
authorized, run `mise exec -- lefthook run pre-commit` before committing in a
repo that configures Lefthook, or the repo's documented pre-commit checks in
one that doesn't. Without authorization, stop before any commit that would
run unapproved hooks or filters.
- LF line endings; always end files with a trailing newline.
- Don't hand-edit generated files (`CHANGELOG.md`, release-please manifests,
lockfiles) — regenerate them via their owning tool.
10 changes: 8 additions & 2 deletions .apm/skills/commit-and-release/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,18 @@ reproducible commands. Record the context identifier and results; after a fix,
start a new tester rather than reusing its conversation. A fresh task/subagent
is sufficient; no orchestration framework is needed.

If the repo configures Lefthook (a Lefthook config such as `lefthook.yml` or
`.lefthook.toml`), run:

```sh
mise exec -- lefthook run pre-commit
```

Plus the repo's own test command, if any. If anything fails, **stop and report**
— do not commit or open a PR with known-failing checks.
Otherwise run the lint and hook checks the repo documents (for example in
`CONTRIBUTING.md`); don't add or install Lefthook just for this step.

Either way, also run the repo's own test command, if any. If anything fails,
**stop and report** — do not commit or open a PR with known-failing checks.

### 5. Commit and push

Expand Down
Loading