Skip to content

chore(mise): use LF line endings so Renovate reads min_version - #202

Merged
DevSecNinja merged 1 commit into
mainfrom
steward/mise-lf
Nov 18, 2026
Merged

DevSecNinja merged 1 commit into
mainfrom
steward/mise-lf

Conversation

@DevSecNinja

@DevSecNinja DevSecNinja commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Description

The shared Renovate manager for min_version didn't match .mise.toml because the file had CRLF line endings, so the mise minimum version was never updated.

Changes

  • .mise.toml: CRLF to LF (no content change), as .editorconfig requires. The shared min_version manager matches the file afterwards (checked with its regex: jdx/mise 2026.4.3).

Closes #201

Checklist

  • Linting passes locally (mise exec -- lefthook run pre-commit)
  • Commit messages follow Conventional Commits
  • Documentation updated (if applicable)

Validation (static and API-only; the repo was not cloned and nothing was executed in it): changed JSON5
files parse, and every new or affected Renovate regex was run (in Python, with RE2/JS named groups
translated) against the files on main. Each matches exactly the lines listed above.
renovate-config-validator was not run (the npm registry is blocked on the authoring machine). Renovate
validates the config on its next run and reports problems on the Dependency Dashboard.

Summary by CodeRabbit

  • Chores
    • Normalized line endings in a configuration file.

@DevSecNinja
DevSecNinja requested a balanced review from Copilot November 17, 2026 16:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request normalizes line endings in .mise.toml. It does not change the configuration content.

Changes: Configuration line endings

Layer / File(s) Summary
Normalize .mise.toml line endings
.mise.toml
The file’s line endings are normalized. Its configuration content is unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: Minimal · up to 28769

This change converts .mise.toml to LF line endings so Renovate can track the min_version pin. No runtime behavior changes, and the merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title states the main change: .mise.toml moves from CRLF to LF line endings, with no content change, so the Renovate manager can match the min_version annotation. The title names the file's pu…
Linked Issues check Passed Issue #201 requires Renovate to track the min_version pin in .mise.toml. The issue scopes this to .mise.toml only and excludes other CRLF files. The whole-PR diff (merge base cbb0233 to head 287694a) …
Out of Scope Changes check Passed The whole-PR diff touches only .mise.toml. That file is the sole target of issue #201. The change is a line-ending normalization with no content change, which directly implements the linked objective.…
Full details: Title check

Explanation

The title states the main change: .mise.toml moves from CRLF to LF line endings, with no content change, so the Renovate manager can match the min_version annotation. The title names the file's purpose (Renovate reads min_version) and the reason, and the changeset matches it. The title uses the conventional commit prefix chore(mise):, which is acceptable.

Full details: Linked Issues check

Explanation

Issue #201 requires Renovate to track the min_version pin in .mise.toml. The issue scopes this to .mise.toml only and excludes other CRLF files. The whole-PR diff (merge base cbb0233 to head 287694a) changes only .mise.toml. The diff shows the same 18 lines of content on both sides, so the change is a line-ending normalization from CRLF to LF. The shared min_version manager regex expects \n between the annotation and min_version, so the LF file lets it match. The PR reports a static regex check against the file, which supports this. No automated test is required by the issue. The unchecked local lint item is a process step, not a coding requirement. Residual uncertainty: the diff view does not show raw bytes, so the LF conversion itself is supported by the diff and the PR description, not by a byte-level check.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff touches only .mise.toml. That file is the sole target of issue #201. The change is a line-ending normalization with no content change, which directly implements the linked objective. No unrelated file or content change is present.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 94c9533e-e25b-45a1-94f5-193561acf561
Commits

Reviewing files that changed from the base of the PR and between cbb0233 and 287694a.

Files selected for processing: 1

  • .mise.toml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@DevSecNinja
DevSecNinja merged commit b53a816 into main Nov 18, 2026
14 checks passed
@DevSecNinja
DevSecNinja deleted the steward/mise-lf branch November 18, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Renovate ignores the min_version annotation in .mise.toml (CRLF line endings)

2 participants