Skip to content

ci: brace variable references for the central shellcheck config #212

Closed

Description

@DevSecNinja

The central .shellcheckrc that config-sync brings in (#211) enables shellcheck's optional require-variable-braces check. Three scripts reference variables without braces, so lint / shellcheck fails on the sync PR with 66 SC2250 findings:

  • .devcontainer/post-create.sh (12 lines)
  • ansible/scripts/ansible-pull.sh (18 lines)
  • tests/bash/run-tests.sh (33 lines)

The fix is mechanical: write $var as ${var}. Nothing else changes.

Part of DevSecNinja/repo-steward#73 (batch 4e-1 post-merge).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions