Skip to content

ci: pin .github callers to v4.2.0 - #1068

Merged
DevSecNinja merged 1 commit into
mainfrom
steward/config-sync-v4-2-0
Nov 17, 2026
Merged

DevSecNinja merged 1 commit into
mainfrom
steward/config-sync-v4-2-0

Conversation

@DevSecNinja

@DevSecNinja DevSecNinja commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Closes #1067

Changes

  • .github/workflows/config-sync.yml: pin to v4.2.0 (5eceec313066eefaa0fe9e3dbf4f9a5a49b55ebd).
  • .github/workflows/release-please.yml: pin to v4.2.0 (5eceec313066eefaa0fe9e3dbf4f9a5a49b55ebd).
  • home/dot_local/bin/.editorconfig: added.

Adds home/dot_local/bin/.editorconfig (indent_size = 4, no root = true) so the indent rule for extensionless scripts survives config-sync replacing the root .editorconfig (DevSecNinja/.github#513). chezmoi ignores dot-prefixed source files, so it isn't deployed.

release-please.yml is unchanged since v3.4.0. config-sync.yml keeps the same inputs, secrets and permissions. It now checks out with persist-credentials: false, commits through open-pr v4.1.0 (commit-method: api, signed by GitHub) and treats renovate.json5 as create-only. The sync warns while renovate.json5 doesn't extend github>DevSecNinja/.github//.renovate/default.json5; converting it is DevSecNinja/.github#513.

Post-merge check

  • Release Please on the merge push is green (when the repo has a release-please caller).
  • Dispatch Config Sync: green, and the sync PR commit is Verified and doesn't touch renovate.json5.
  • Held sync PR chore: sync config files from central repo #1066 is regenerated from main (signed) and mergeable.

Part of DevSecNinja/repo-steward#73 (batch 4, owner-approved). Opened by repo-steward through the GitHub API; the commit is signed by GitHub (createCommitOnBranch).

Summary by CodeRabbit

  • Chores
    • Updated the configuration used by automated release and configuration-sync workflows.
  • Style
    • Standardized indentation settings for extensionless scripts.

No changes to the end-user experience are included in this update.

Part of DevSecNinja/repo-steward#73 (batch 4).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request updates two reusable workflow references to v4.2.0. It also adds a local EditorConfig file with comments and a catch-all indentation setting of 4.

Changes: Reusable Workflow Pins

Layer / File(s) Summary
Update reusable workflow references
.github/workflows/config-sync.yml, .github/workflows/release-please.yml
Both workflow jobs now reference the v4.2.0 revision instead of v3.7.1.

Local EditorConfig

Layer / File(s) Summary
Set local indentation
home/dot_local/bin/.editorconfig
Adds comments about extensionless scripts, inherited repository configuration, and chezmoi deployment. Sets indent_size = 4 for all files.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other · Severity of issue fixed: Medium

Possibly related issues

  • Issue 1062 — The pull request updates the same two workflow callers, but the supplied scope does not confirm the App credential or gitleaks changes described in that issue.

Possibly related PRs

  • DevSecNinja/dotfiles#1063 — It updates the same two reusable workflow references to v3.7.1; this pull request changes those references to v4.2.0.
Merge Risk: Minimal · up to 4130b

This updates CI workflow pins and adds a local indentation setting. No concrete problems were found, so it is low risk to merge. The listed post-merge workflow runs should still confirm the sync behavior.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "ci: pin .github callers to v4.2.0" matches the main change. The PR updates the sync job in config-sync.yml and the release-please job in release-please.yml to reference DevSecNinja/.github …
Linked Issues check Passed Issue #1067 has one coding objective: pin the .github callers to v4.2.0. At the reviewed head, .github/workflows/config-sync.yml and .github/workflows/release-please.yml both call `DevSecNinja/.…
Out of Scope Changes check Passed The change set has three files. Two are the pin changes required by #1067. The third, home/dot_local/bin/.editorconfig, adds a catch-all [*] section with indent_size = 4 and no root = true. Th…
Full details: Title check

Explanation

The title "ci: pin .github callers to v4.2.0" matches the main change. The PR updates the sync job in config-sync.yml and the release-please job in release-please.yml to reference DevSecNinja/.github v4.2.0 at commit 5eceec31. The title does not mention the added home/dot_local/bin/.editorconfig, which is a minor supporting change and does not need to be in the title.

Full details: Linked Issues check

Explanation

Issue #1067 has one coding objective: pin the .github callers to v4.2.0. At the reviewed head, .github/workflows/config-sync.yml and .github/workflows/release-please.yml both call DevSecNinja/.github/.github/workflows/&lt;name&gt;.yml@5eceec313066eefaa0fe9e3dbf4f9a5a49b55ebd # v4.2.0. This meets the pin requirement. The issue also states two behaviors of v4.2.0: create-only renovate.json5 (DevSecNinja/.github#518) and API-signed sync commits (DevSecNinja/.github#538). These come from the upstream reusable workflow at the pinned revision. This repository does not implement them, and this review did not read the upstream workflow, so they are accepted from the pin and the issue text. Regenerating held sync PR #1066 and the post-merge checks are non-coding and are not assessed. The .github diff tool was unavailable, so the before/after comparison relies on the head file contents.

Full details: Out of Scope Changes check

Explanation

The change set has three files. Two are the pin changes required by #1067. The third, home/dot_local/bin/.editorconfig, adds a catch-all [*] section with indent_size = 4 and no root = true. The file content at head matches the PR description. The PR description links the file to the root .editorconfig replacement by config-sync (DevSecNinja/.github#513), which is a consequence of the sync work in #1067. The file does not alter deployed configuration, because chezmoi ignores dot-prefixed source files. The connection is stated but is not stated in #1067 itself, so it rests on the PR description. No unrelated change was found.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f6064b67-d5e7-4531-8dc1-4c7fdcb1d1e2
Commits

Reviewing files that changed from the base of the PR and between 8920c3b and 4130b33.

Files selected for processing: 3

  • .github/workflows/config-sync.yml
  • .github/workflows/release-please.yml
  • home/dot_local/bin/.editorconfig

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the workflow-pin updates and directory-level EditorConfig rule.

No open issues 🎉

What changed in this PR

Updates the dotfiles repository’s shared workflow pins to v4.2.0, adopting signed config-sync commits and create-only handling of renovate.json5.

Changes:

  • Pins Config Sync and Release Please to the v4.2.0 commit.
  • Adds a directory-level EditorConfig rule to preserve four-space indentation for extensionless scripts when config-sync replaces the root configuration.
File Description
home/​dot_local/​bin/​.editorconfig Preserves four-space indentation while inheriting root settings.
.github/​workflows/​release-please.yml Updates the shared Release Please workflow pin to v4.2.0.
.github/​workflows/​config-sync.yml Updates the shared Config Sync workflow pin to v4.2.0.

Review effort: Balanced

@DevSecNinja
DevSecNinja merged commit 803867b into main Nov 17, 2026
18 checks passed
@DevSecNinja
DevSecNinja deleted the steward/config-sync-v4-2-0 branch November 17, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: pin .github callers to v4.2.0 (signed config-sync, create-only renovate.json5)

2 participants