Skip to content

ci: add the standard lint and secret-scan CI - #1082

Open
DevSecNinja wants to merge 4 commits into
steward/lint-debtfrom
steward/lint-ci
Open

DevSecNinja wants to merge 4 commits into
steward/lint-debtfrom
steward/lint-ci

Conversation

@DevSecNinja

@DevSecNinja DevSecNinja commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Adds the standard DevSecNinja lint and secret-scan CI from repo-steward's workflow templates, on DevSecNinja/.github v4.7.0.

  • .github/workflows/lint.yml runs on pull requests and on pushes to main.
    • It runs dprint, yamlfmt, yamllint, actionlint, gitleaks, shellcheck, shfmt, checkov, trivy and zizmor, one job per linter. Linters only report: lint-fail-on-error is off.
    • gitleaks on a PR scans only that PR's commits. trivy, zizmor and checkov upload SARIF to code scanning.
    • v4.7.0 also has ruff, Biome and PSScriptAnalyzer. They stay off here until the repo opts in: ruff and Biome need a pin in .mise.toml, and PSScriptAnalyzer needs psscriptanalyzer-version. That is a separate decision (DevSecNinja/repo-steward#133). The inline-scripts check only warns.
  • .github/workflows/secret-scan.yml calls lint-include.yml, where every linter is off unless enabled, with only lint-gitleaks: true. It scans the full git history on push to main, weekly (Mon 05:23 UTC) and on demand. Findings go to code scanning (category gitleaks/history), where only people with write access see them; the public log shows a count only.
  • .mise.toml pins the lint tools. shellcheck and shfmt move from latest to exact versions, so lint runs are reproducible; Renovate keeps them current. lefthook uses the same versions.
  • shellcheck: this repo's .shellcheckrc comes from config-sync, which copies from DevSecNinja/.github main. Until the first sync PR after fix(config-sync): drop two optional shellcheck checks from .shellcheckrc .github#586 merges (it drops SC2310, SC2311 and SC2312), the shellcheck job reports those findings. .lefthook.toml already skips them.

Stacked on the lint-debt PR, which brings the formatting: merge that one first. Public repo, so Actions minutes are free.

Opened by repo-steward (findings baseline/required-file@dotfiles#lint and #secret-scan, rollout batch B2). Merging this PR is the approval; close it to decline.

Closes #1081

Add the lint and secret-scan callers from repo-steward's workflow
templates on DevSecNinja/.github v4.7.0. secret-scan.yml calls
lint-include.yml with only lint-gitleaks: true.

.mise.toml pins the lint tools the workflow installs, including
shellcheck and shfmt, which were "latest", so lint runs are reproducible.
Renovate keeps them current.

Closes #1081
@DevSecNinja
DevSecNinja added this pull request to stack #1084 November 18, 2026 15:22
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 37 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cf77fc19-cb19-4c33-a5d7-d65718af3226
Commits

Reviewing files that changed from the base of the PR and between 2480902 and 1f27d84.

Files selected for processing: 8

  • .github/workflows/ci.yaml
  • .github/workflows/devcontainer-prebuild.yaml
  • .github/workflows/lint.yml
  • .github/workflows/release.yml
  • .github/workflows/secret-scan.yml
  • .github/workflows/sign-powershell.yml
  • .mise.toml
  • docs/yubikey.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

1 similar comment
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the shared lint and security workflow additions.

No open issues 🎉

What changed in this PR

Adds the standard DevSecNinja lint and security workflows to this dotfiles repository, addressing #1081 through shared CI pinned to v4.7.0.

Changes:

  • Adds reporting-only lint checks for pull requests and pushes to main.
  • Adds full-history secret scanning on pushes to main, weekly, and on demand, with findings sent to code scanning.
  • Pins lint tool versions in mise, including shellcheck and shfmt used by local hooks.
File Description
.mise.toml Pins tools used by the shared lint workflows and local shell hooks.
.github/​workflows/​secret-scan.yml Adds the gitleaks-only full-history scan caller.
.github/​workflows/​lint.yml Adds the shared lint caller with shell-tool exclusions for vendored Spec Kit scripts.

Review effort: Balanced

Same change as the lint-debt PR below (quote $GITHUB_OUTPUT for
actionlint, SC2086), applied here so this branch's lint run checks the
fixed files. The stack's update-branch isn't available for stacked PRs.

Refs #1081
Reflow the paragraph so "touch + PIN" no longer starts a line with "+",
which made dprint (and CommonMark) read it as a list item. Same wording.

Refs #1081
Two actionlint findings, per the owner's decisions:

- release.yml: the printf lines print a ready-to-copy shell snippet whose
  $tmp and $HOME must stay literal. Disable SC2016 for that block, with
  the reason (T154 a).
- sign-powershell.yml: remove the "Comment on PR" step. It referenced a
  step (check_changes) that no longer exists, and the workflow never runs
  on pull_request, so the step never ran (T155 a).

No behaviour change.

Refs #1081

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review reports no active issues with the lint and security workflow changes.

No open issues 🎉

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the standard lint and secret-scan CI

3 participants