Repository navigation
ci: add the standard lint and secret-scan CI - #1082
DevSecNinja wants to merge 4 commits into
Conversation
Add the lint and secret-scan callers from repo-steward's workflow templates on DevSecNinja/.github v4.7.0. secret-scan.yml calls lint-include.yml with only lint-gitleaks: true. .mise.toml pins the lint tools the workflow installs, including shellcheck and shfmt, which were "latest", so lint runs are reproducible. Renovate keeps them current. Closes #1081
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 37 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
1 similar comment
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the shared lint and security workflow additions.
No open issues 🎉
What changed in this PR
Adds the standard DevSecNinja lint and security workflows to this dotfiles repository, addressing #1081 through shared CI pinned to v4.7.0.
Changes:
- Adds reporting-only lint checks for pull requests and pushes to
main. - Adds full-history secret scanning on pushes to
main, weekly, and on demand, with findings sent to code scanning. - Pins lint tool versions in mise, including shellcheck and shfmt used by local hooks.
| File | Description |
|---|---|
.mise.toml |
Pins tools used by the shared lint workflows and local shell hooks. |
.github/workflows/secret-scan.yml |
Adds the gitleaks-only full-history scan caller. |
.github/workflows/lint.yml |
Adds the shared lint caller with shell-tool exclusions for vendored Spec Kit scripts. |
Review effort: Balanced
Same change as the lint-debt PR below (quote $GITHUB_OUTPUT for actionlint, SC2086), applied here so this branch's lint run checks the fixed files. The stack's update-branch isn't available for stacked PRs. Refs #1081
Reflow the paragraph so "touch + PIN" no longer starts a line with "+", which made dprint (and CommonMark) read it as a list item. Same wording. Refs #1081
Two actionlint findings, per the owner's decisions: - release.yml: the printf lines print a ready-to-copy shell snippet whose $tmp and $HOME must stay literal. Disable SC2016 for that block, with the reason (T154 a). - sign-powershell.yml: remove the "Comment on PR" step. It referenced a step (check_changes) that no longer exists, and the workflow never runs on pull_request, so the step never ran (T155 a). No behaviour change. Refs #1081
Adds the standard DevSecNinja lint and secret-scan CI from repo-steward's workflow templates, on DevSecNinja/.github v4.7.0.
.github/workflows/lint.ymlruns on pull requests and on pushes tomain.lint-fail-on-erroris off..mise.toml, and PSScriptAnalyzer needspsscriptanalyzer-version. That is a separate decision (DevSecNinja/repo-steward#133). The inline-scripts check only warns..github/workflows/secret-scan.ymlcallslint-include.yml, where every linter is off unless enabled, with onlylint-gitleaks: true. It scans the full git history on push tomain, weekly (Mon 05:23 UTC) and on demand. Findings go to code scanning (categorygitleaks/history), where only people with write access see them; the public log shows a count only..mise.tomlpins the lint tools. shellcheck and shfmt move fromlatestto exact versions, so lint runs are reproducible; Renovate keeps them current. lefthook uses the same versions..shellcheckrccomes from config-sync, which copies from DevSecNinja/.githubmain. Until the first sync PR after fix(config-sync): drop two optional shellcheck checks from .shellcheckrc .github#586 merges (it drops SC2310, SC2311 and SC2312), the shellcheck job reports those findings..lefthook.tomlalready skips them.Stacked on the lint-debt PR, which brings the formatting: merge that one first. Public repo, so Actions minutes are free.
Opened by repo-steward (findings
baseline/required-file@dotfiles#lintand#secret-scan, rollout batch B2). Merging this PR is the approval; close it to decline.Closes #1081