Skip to content

ci: shell scripts fail shellcheck and shfmt under the central lint config #451

Closed

Description

@DevSecNinja

The config-sync PR #450 brings in the central, stricter .shellcheckrc and the .editorconfig with [*.sh] indent_size = 4. With them, two lint jobs fail on the shell scripts already on main:

  • lint / shellcheck (shellcheck 0.11.0): SC2250 (braces around variable references) in 15 scripts, SC2248 (quoting) once and SC2312 (masked return values) in 5 places.
  • lint / shfmt (shfmt 3.14.1): all 21 scripts are tab-indented, and the new .editorconfig asks for 4 spaces.

The fix is mechanical and should not change behaviour:

  • reformat every *.sh with shfmt -w under the new .editorconfig;
  • apply shellcheck's own autofixes for SC2250/SC2248;
  • resolve the five SC2312 notes without changing what happens on failure (split the command substitution with || true where the failure was already masked, or a justified # shellcheck disable=SC2312 where timeout is expected to stop index-now);
  • ship the central .editorconfig and .shellcheckrc in the same PR, so its own lint run enforces the result.

Once this is merged, #450 only carries the remaining synced files and should go green.

Found while preparing #450 for merge (DevSecNinja/repo-steward fleet maintenance).

Activity

  1. added a commit that references this issue on Nov 16, 2026
    4300838
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingenhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions