Repository navigation
fix(reminders): keep calls whole across unclear checks and honor the shown interval - #35
Merged
Merged
Conversation
…shown interval - Extend the open call when no check saw it end, so checks that could not tell during a long overrun no longer split it and cut the reminder window short. - Schedule in-call lookups with the interval shown in Settings, so a hand-edited value such as 7 minutes runs every 10 as displayed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Disabling reminders leaves the call-continuation flag set, so re-enabling during a later call can incorrectly merge separate calls and trigger reminders for skipped meetings.
1 open issue
What changed in this PR
This follow-up to #28 improves call tracking and aligns in-call meeting refresh timing with the interval shown in Settings.
Changes:
- Preserve a single call span across inconclusive presence checks.
- Use the Settings-snapped interval when scheduling meeting lookups.
- Add regression tests for long detection gaps and hand-edited intervals.
| File | Description |
|---|---|
| crates/noteiq-core/tests/meeting_reminder_tests.rs | Tests call continuity and updates recording calls to pass continuation state. |
| crates/noteiq-core/src/meeting_reminder.rs | Allows ongoing calls to extend across long detection gaps. |
| apps/noteiq-windows/src/ui.rs | Passes call continuation state and schedules lookups using the displayed interval. |
Review effort: Balanced
… off Re-enabling reminders during a later call could bridge the gap and count meetings in between as attended. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Follow-up to #28. It addresses the two issues Copilot's last review of #28 reported in its summary ("previously missed issues"), which weren't posted as review threads.
Changes
ReminderHistory::record_call(now, continuing)now extends the open call when no check saw it end in between.in_call_refresh_minutes = 7showed as "Every 10 minutes" but was scheduled every 7. Scheduling now uses the same snapped value as Settings (effective_in_call_refresh_minutes).Validation
checks_that_could_not_tell_do_not_split_a_call_that_runs_on, and the hand-edited interval case inmeetings_are_looked_up_every_few_minutes_during_a_call_while_the_window_is_open.cargo test --workspace --features noteiq-windows/desktop --locked(353 passed),cargo clippy -D warnings, and the lefthook pre-commit hooks (cargo-fmt, dprint, gitleaks) are clean.