Skip to content

fix(reminders): keep calls whole across unclear checks and honor the shown interval - #35

Merged
DevSecNinja merged 2 commits into
mainfrom
devsecninja-meeting-reminders-and-templates
Nov 15, 2026
Merged

DevSecNinja merged 2 commits into
mainfrom
devsecninja-meeting-reminders-and-templates

Conversation

@DevSecNinja

Copy link
Copy Markdown
Owner

Follow-up to #28. It addresses the two issues Copilot's last review of #28 reported in its summary ("previously missed issues"), which weren't posted as review threads.

Changes

  • Calls aren't split by checks that couldn't tell. If the call check fails for more than 2 minutes during a call that runs past the meeting, the call was split into two spans. The reminder window then counted from the end of the first span, so the reminder could be dropped as soon as the user left. ReminderHistory::record_call(now, continuing) now extends the open call when no check saw it end in between.
  • Lookups use the interval Settings shows. A hand-edited in_call_refresh_minutes = 7 showed as "Every 10 minutes" but was scheduled every 7. Scheduling now uses the same snapped value as Settings (effective_in_call_refresh_minutes).

Validation

  • New tests: checks_that_could_not_tell_do_not_split_a_call_that_runs_on, and the hand-edited interval case in meetings_are_looked_up_every_few_minutes_during_a_call_while_the_window_is_open.
  • cargo test --workspace --features noteiq-windows/desktop --locked (353 passed), cargo clippy -D warnings, and the lefthook pre-commit hooks (cargo-fmt, dprint, gitleaks) are clean.

…shown interval

- Extend the open call when no check saw it end, so checks that could not
  tell during a long overrun no longer split it and cut the reminder
  window short.
- Schedule in-call lookups with the interval shown in Settings, so a
  hand-edited value such as 7 minutes runs every 10 as displayed.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Disabling reminders leaves the call-continuation flag set, so re-enabling during a later call can incorrectly merge separate calls and trigger reminders for skipped meetings.

1 open issue
What changed in this PR

This follow-up to #28 improves call tracking and aligns in-call meeting refresh timing with the interval shown in Settings.

Changes:

  • Preserve a single call span across inconclusive presence checks.
  • Use the Settings-snapped interval when scheduling meeting lookups.
  • Add regression tests for long detection gaps and hand-edited intervals.
File Description
crates/​noteiq-core/​tests/​meeting_reminder_tests.rs Tests call continuity and updates recording calls to pass continuation state.
crates/​noteiq-core/​src/​meeting_reminder.rs Allows ongoing calls to extend across long detection gaps.
apps/​noteiq-windows/​src/​ui.rs Passes call continuation state and schedules lookups using the displayed interval.

Review effort: Balanced

Comment thread apps/noteiq-windows/src/ui.rs Resolved
… off

Re-enabling reminders during a later call could bridge the gap and count
meetings in between as attended.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the reminder call-tracking and refresh-interval changes.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@DevSecNinja
DevSecNinja merged commit 19ca36e into main Nov 15, 2026
24 checks passed
@DevSecNinja
DevSecNinja deleted the devsecninja-meeting-reminders-and-templates branch November 15, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants