Repository navigation
fix: keep NoteIQ's taskbar icon and explain language errors in Tidy up - #36
Merged
Merged
Conversation
- With the package identity Tidy up needs, the taskbar drew the package logo as a blank tile. Give the capture window its own app ID and relaunch properties so the taskbar uses the window icon again. - Windows rejects short lowercase notes full of abbreviations as an unknown language. Say so and suggest capitalizing acronyms or writing a full sentence, instead of claiming the language is unsupported. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #30, from testing on a Surface Laptop 7.
Taskbar icon
With the package identity Tidy up needs (
scripts/register-package.ps1), Windows grouped the window under the package and drew a blank grey tile. Without the registration the icon was fine.Tried first, without success: full Square44x44 target-size and scale assets with
resources.pri(still grey), and removingAppListEntry="none"(the taskbar button disappeared entirely).The fix is in
apps/noteiq-windows/src/taskbar.rs. When running with package identity, the window gets its own app ID (DevSecNinja.NoteIQ.Capture, deliberately not the notification app ID) and relaunch command, display name, and icon. It does this throughSHGetPropertyStoreForWindow, with strings in COM memory. A first attempt that passed a Rust buffer crashed with heap corruption (0xc0000374). Toasts are unaffected because they use an explicit notifier ID.Language error
Windows' built-in model rejects short lowercase notes with abbreviations as
UnsupportedLanguage, even when they're English. For example,deal alm closed\nneed pipeline update msxfails, whileDeal ALM closed.\nNeed pipeline update in MSX.works. NoteIQ can't override Windows' language detection, so the message now explains this and suggests a workaround.docs/setup.mdcovers it too.Validation
cargo fmt --check,dprint check,cargo clippy --workspace --features noteiq-windows/desktop --all-targets -D warnings, andcargo test --workspace --features noteiq-windows/desktoppass on Windows ARM64.Ready.