Skip to content

ci: migrate App credentials to environment-aware .github v3.6.0 - #38

Merged
DevSecNinja merged 2 commits into
mainfrom
steward/automation-app-callers
Nov 16, 2026
Merged

DevSecNinja merged 2 commits into
mainfrom
steward/automation-app-callers

Conversation

@DevSecNinja

@DevSecNinja DevSecNinja commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Closes #37

Changes

Pinned to v3.7.1 (released 2026-11-16) rather than v3.6.0 so Renovate doesn't open another bump right away. release-please.yml and config-sync.yml are byte-identical between v3.6.0 and v3.7.1 (v3.7.0 adds the ai-commits-badge action, v3.7.1 fixes the synced gitleaks config), so the interface below is unchanged.

  • .github/workflows/release-please.yml: pin release-please.yml v3.0.0 → v3.7.1 (e28a49a14d4530962b165e0d35a8a331b2b42f23), drop the legacy app-id: ${{ vars.RELEASE_PLEASE_APP_ID }} input and replace app-private-key: ${{ secrets.RELEASE_PLEASE_APP_PRIVATE_KEY }} with AUTOMATION_APP_PRIVATE_KEY: ${{ secrets.AUTOMATION_APP_PRIVATE_KEY }}. Outputs (releases_created, tag_name, pr) are unchanged and not consumed here.
  • .github/workflows/config-sync.yml: pin config-sync.yml v2.5.0 → v3.7.1 (e28a49a14d4530962b165e0d35a8a331b2b42f23) and pass AUTOMATION_APP_PRIVATE_KEY: ${{ secrets.AUTOMATION_APP_PRIVATE_KEY }}, so the sync PR is opened by the DevSecNinja Automation App instead of GITHUB_TOKEN (App-opened PRs run CI). v3.7.1 also uses open-pr v3.3.0, which fixes the weekly chore/config-sync "stale info" push failure.

issues: write is dropped from the config-sync job: v3.4.0+ creates the label with the Pull requests permission. docs/setup.md and specs/001-noteiq-capture/* still mention RELEASE_PLEASE_APP_*; they're documentation only and left for a follow-up.

Permissions are unchanged except where noted (contents: write, pull-requests: write cover v3.7.1). The credentials live in the production environment; the reusable job declares it with deployment: false, so the secret passed by name resolves there. A dispatch from a branch other than main now fails on the environment's branch policy, by design.

Post-merge check

  • The merge push runs Release Please on main: green, "Validate GitHub App credentials" passes, and the release PR is opened or updated by devsecninja-automation[bot].
  • Dispatch Config Sync on main: green with no "falls back to GITHUB_TOKEN" warning; any sync PR is authored by devsecninja-automation[bot].
  • Only after those runs: the legacy RELEASE_PLEASE_APP_ID / RELEASE_PLEASE_APP_PRIVATE_KEY can go (DevSecNinja/repo-steward#57; not part of this PR).

Part of DevSecNinja/repo-steward#73 (batch 2, owner-approved). Opened by repo-steward through the GitHub API; both commits are signed by GitHub (createCommitOnBranch).

Part of DevSecNinja/repo-steward#73 (batch 2).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Although pinned workflow contracts match callers, hosted validation is still needed to confirm production credentials, environment branch restrictions, App permissions, and App-generated events triggering downstream CI and publishing.

No open issues 🎉

What changed in this PR

Updates Release Please and Config Sync to the shared .github v3.6.0 workflows, aligning both callers with the production-environment GitHub App credential migration in #37.

Changes:

  • Pins both reusable workflows to the v3.6.0 commit.
  • Passes AUTOMATION_APP_PRIVATE_KEY by name and removes Release Please’s legacy App ID input.
  • Removes Config Sync’s issues: write permission while retaining content and pull-request write access.
File Description
.github/​workflows/​release-please.yml Upgrades the shared workflow and replaces legacy App credential inputs.
.github/​workflows/​config-sync.yml Upgrades the shared workflow, passes the Automation App key, and reduces permissions.

Review effort: Balanced

DevSecNinja/.github v3.7.1 was released on 2026-11-16. release-please.yml and config-sync.yml are
unchanged since v3.6.0, so this only moves the pin and saves a follow-up Renovate bump.

Part of DevSecNinja/repo-steward#73 (batch 2).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@DevSecNinja
DevSecNinja merged commit adeb713 into main Nov 16, 2026
23 checks passed
@DevSecNinja
DevSecNinja deleted the steward/automation-app-callers branch November 16, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: migrate App credential callers to .github v3.6.0

2 participants