Repository navigation
ci: migrate App credentials to environment-aware .github v3.6.0 - #38
Merged
Merged
Conversation
Part of DevSecNinja/repo-steward#73 (batch 2). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Although pinned workflow contracts match callers, hosted validation is still needed to confirm production credentials, environment branch restrictions, App permissions, and App-generated events triggering downstream CI and publishing.
No open issues 🎉
What changed in this PR
Updates Release Please and Config Sync to the shared .github v3.6.0 workflows, aligning both callers with the production-environment GitHub App credential migration in #37.
Changes:
- Pins both reusable workflows to the v3.6.0 commit.
- Passes
AUTOMATION_APP_PRIVATE_KEYby name and removes Release Please’s legacy App ID input. - Removes Config Sync’s
issues: writepermission while retaining content and pull-request write access.
| File | Description |
|---|---|
.github/workflows/release-please.yml |
Upgrades the shared workflow and replaces legacy App credential inputs. |
.github/workflows/config-sync.yml |
Upgrades the shared workflow, passes the Automation App key, and reduces permissions. |
Review effort: Balanced
DevSecNinja/.github v3.7.1 was released on 2026-11-16. release-please.yml and config-sync.yml are unchanged since v3.6.0, so this only moves the pin and saves a follow-up Renovate bump. Part of DevSecNinja/repo-steward#73 (batch 2). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37
Changes
Pinned to v3.7.1 (released 2026-11-16) rather than v3.6.0 so Renovate doesn't open another bump right away.
release-please.ymlandconfig-sync.ymlare byte-identical between v3.6.0 and v3.7.1 (v3.7.0 adds the ai-commits-badge action, v3.7.1 fixes the synced gitleaks config), so the interface below is unchanged..github/workflows/release-please.yml: pinrelease-please.ymlv3.0.0 → v3.7.1 (e28a49a14d4530962b165e0d35a8a331b2b42f23), drop the legacyapp-id: ${{ vars.RELEASE_PLEASE_APP_ID }}input and replaceapp-private-key: ${{ secrets.RELEASE_PLEASE_APP_PRIVATE_KEY }}withAUTOMATION_APP_PRIVATE_KEY: ${{ secrets.AUTOMATION_APP_PRIVATE_KEY }}. Outputs (releases_created,tag_name,pr) are unchanged and not consumed here..github/workflows/config-sync.yml: pinconfig-sync.ymlv2.5.0 → v3.7.1 (e28a49a14d4530962b165e0d35a8a331b2b42f23) and passAUTOMATION_APP_PRIVATE_KEY: ${{ secrets.AUTOMATION_APP_PRIVATE_KEY }}, so the sync PR is opened by the DevSecNinja Automation App instead ofGITHUB_TOKEN(App-opened PRs run CI). v3.7.1 also uses open-pr v3.3.0, which fixes the weeklychore/config-sync"stale info" push failure.issues: writeis dropped from the config-sync job: v3.4.0+ creates the label with the Pull requests permission.docs/setup.mdandspecs/001-noteiq-capture/*still mentionRELEASE_PLEASE_APP_*; they're documentation only and left for a follow-up.Permissions are unchanged except where noted (
contents: write,pull-requests: writecover v3.7.1). The credentials live in theproductionenvironment; the reusable job declares it withdeployment: false, so the secret passed by name resolves there. A dispatch from a branch other thanmainnow fails on the environment's branch policy, by design.Post-merge check
main: green, "Validate GitHub App credentials" passes, and the release PR is opened or updated bydevsecninja-automation[bot].main: green with no "falls back to GITHUB_TOKEN" warning; any sync PR is authored bydevsecninja-automation[bot].RELEASE_PLEASE_APP_ID/RELEASE_PLEASE_APP_PRIVATE_KEYcan go (DevSecNinja/repo-steward#57; not part of this PR).Part of DevSecNinja/repo-steward#73 (batch 2, owner-approved). Opened by repo-steward through the GitHub API; both commits are signed by GitHub (
createCommitOnBranch).