Repository navigation
fix(a11y): use role="none" on the decorative header icon - #260
Conversation
html-validate 11.21 added the presentation-role-style rule, which prefers role="none" to role="presentation". The header icon is already hidden from assistive tech by its aria-hidden wrapper, so the two roles are equivalent. This unblocks the weekly Renovate PR #254 (html-validate 11.17 to 11.21) once Renovate rebases it.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
🟢 Approval recommended
The decorative header SVG role update has no active review issues.
No open issues 🎉
What changed in this PR
Updates the decorative header icon to satisfy html-validate’s presentation-role-style rule, addressing #259 and the validation failure reported in dependency update PR #254.
Changes:
- Replaces
role="presentation"with the equivalentrole="none". - Preserves the existing
aria-hiddenwrapper and the icon’s appearance.
| File | Description |
|---|---|
index.html |
Uses role="none" on the decorative header SVG. |
Review effort: Balanced
|
🔍 Preview deployed: https://faeb9e2f.v60-brew-guide.pages.dev Updated: Wed, 18 Nov 2026 16:10:07 GMT |
Description
html-validate 11.21 added the
presentation-role-stylerule, which fails the Pages test job on Renovate PR #254. This changes the decorative header icon torole="none", the form the rule prefers. It's equivalent torole="presentation", and the icon'saria-hiddenwrapper already hides it from assistive tech. #254 should go green after Renovate rebases it in its Saturday window.Closes #259
Changes
index.html: the header icon<svg>getsrole="none"instead ofrole="presentation"(one attribute).Checklist
mise exec -- lefthook run pre-commit): not run. repo-steward works API-only without a clone, so CI is the check.steward commit-files)Summary by CodeRabbit
presentationtonone. This updates how the logo’s role is identified in the page’s accessibility information; the logo’s appearance and placement are unchanged.