Skip to content

fix(a11y): use role="none" on the decorative header icon - #260

Merged
DevSecNinja merged 1 commit into
mainfrom
steward/html-validate-presentation-role
Nov 18, 2026
Merged

DevSecNinja merged 1 commit into
mainfrom
steward/html-validate-presentation-role

Conversation

@DevSecNinja

@DevSecNinja DevSecNinja commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Description

html-validate 11.21 added the presentation-role-style rule, which fails the Pages test job on Renovate PR #254. This changes the decorative header icon to role="none", the form the rule prefers. It's equivalent to role="presentation", and the icon's aria-hidden wrapper already hides it from assistive tech. #254 should go green after Renovate rebases it in its Saturday window.

Closes #259

Changes

  • index.html: the header icon <svg> gets role="none" instead of role="presentation" (one attribute).

Checklist

  • Linting passes locally (mise exec -- lefthook run pre-commit): not run. repo-steward works API-only without a clone, so CI is the check.
  • Commit messages follow Conventional Commits (signed commit via steward commit-files)
  • Documentation updated (if applicable): not needed

Summary by CodeRabbit

  • Accessibility
    • The header logo’s accessibility role has changed from presentation to none. This updates how the logo’s role is identified in the page’s accessibility information; the logo’s appearance and placement are unchanged.

html-validate 11.21 added the presentation-role-style rule, which prefers
role="none" to role="presentation". The header icon is already hidden from
assistive tech by its aria-hidden wrapper, so the two roles are equivalent.

This unblocks the weekly Renovate PR #254 (html-validate 11.17 to 11.21)
once Renovate rebases it.
@DevSecNinja
DevSecNinja requested a balanced review from Copilot November 18, 2026 16:05
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The header logo SVG’s role changes from presentation to none.

Changes: Header logo accessibility role

Layer / File(s) Summary
Update the SVG role
index.html
The header logo SVG uses role="none" instead of role="presentation".

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other · Severity of issue fixed: Low

Suggested reviewers: copilot

Merge Risk: Minimal · up to 03221

This is a one-attribute accessibility markup change that satisfies the html-validate rule without altering behavior or appearance. Merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the change: the decorative header icon's role is changed from presentation to none to fix an a11y validation failure. The raw summary confirms the only change is the SVG role in index.…
Linked Issues check Passed [#259] requires resolving the html-validate presentation-role-style failure on the header icon <svg> in index.html (reported at line 1925). The diff against the merge base changes only that elem…
Out of Scope Changes check Passed The whole-PR diff against the merge base touches one file, index.html, in one hunk. The single changed line is the role attribute on the header icon <svg> that #259 names. No other changes appea…
Full details: Title check

Explanation

The title names the change: the decorative header icon's role is changed from presentation to none to fix an a11y validation failure. The raw summary confirms the only change is the SVG role in index.html, and the objectives link it to issue #259 (html-validate presentation-role-style rule). The title is specific, concise, and follows the conventional commit format.

Full details: Linked Issues check

Explanation

[#259] requires resolving the html-validate presentation-role-style failure on the header icon &lt;svg&gt; in index.html (reported at line 1925). The diff against the merge base changes only that element's role attribute from presentation to none. The &lt;svg&gt; sits inside &lt;div class="header-icon" aria-hidden="true"&gt;, so the issue's described context matches the code. No automated test change is included or required by the issue. The only remaining check is the Pages test job, which is CI and outside this diff. The Renovate PR #254 rebase is an external event, not a requirement of this PR.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff against the merge base touches one file, index.html, in one hunk. The single changed line is the role attribute on the header icon &lt;svg&gt; that #259 names. No other changes appear in the reviewed diff. The local lint step in the PR checklist is a process item, not a code change, so it does not affect scope.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a49971b8-f9f0-485d-bf2b-afb260a468cf
Commits

Reviewing files that changed from the base of the PR and between 1bb58ac and 03221a4.

Files selected for processing: 1

  • index.html

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The decorative header SVG role update has no active review issues.

No open issues 🎉

What changed in this PR

Updates the decorative header icon to satisfy html-validate’s presentation-role-style rule, addressing #259 and the validation failure reported in dependency update PR #254.

Changes:

  • Replaces role="presentation" with the equivalent role="none".
  • Preserves the existing aria-hidden wrapper and the icon’s appearance.
File Description
index.html Uses role="none" on the decorative header SVG.

Review effort: Balanced

@github-actions

Copy link
Copy Markdown

🔍 Preview deployed: https://faeb9e2f.v60-brew-guide.pages.dev

Updated: Wed, 18 Nov 2026 16:10:07 GMT

@DevSecNinja
DevSecNinja merged commit c61bcdd into main Nov 18, 2026
12 checks passed
@DevSecNinja
DevSecNinja deleted the steward/html-validate-presentation-role branch November 18, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

html-validate 11.21 fails the HTML test on role="presentation"

2 participants