Skip to content

ci: add lint and secret-scan caller workflows - #61

Merged
DevSecNinja merged 3 commits into
mainfrom
steward/lint-ci
Nov 17, 2026
Merged

DevSecNinja merged 3 commits into
mainfrom
steward/lint-ci

Conversation

@DevSecNinja

@DevSecNinja DevSecNinja commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Adds the standard DevSecNinja lint and secret-scan CI, from repo-steward's workflow templates, both on DevSecNinja/.github v4.4.0.

  • .github/workflows/lint.yml runs on pull requests and on pushes to main. It runs dprint, yamlfmt, yamllint, actionlint, gitleaks, shellcheck, shfmt, checkov, trivy and zizmor, one job per linter. gitleaks on a PR scans only that PR's commits. trivy, zizmor and checkov upload SARIF to code scanning. Linters only report: lint-fail-on-error is off, so a finding never blocks a merge.
  • .github/workflows/secret-scan.yml calls lint-include.yml, where every linter is off unless enabled, with only lint-gitleaks: true. It runs gitleaks alone over the full git history on push to main, weekly (Mon 05:23 UTC) and on demand, so new gitleaks rules re-check old commits. Findings go to code scanning (category gitleaks/history), where only people with write access see them. The public log shows a count only.
  • The tools come from this repo's .mise.toml, which Renovate keeps current.

Lint debt: adopts the central lint configs from DevSecNinja/.github config-sync/files at v4.2.0, unchanged, as config-sync would deliver them: dprint.json and .editorconfig replace the local copies, .yamlfmt.yaml replaces .yamlfmt, and .yamllint.yaml is new. The central configs exclude release-please's CHANGELOG.md and Spec Kit output, so no source file changes. The local dprint.json also formatted TS, CSS, HTML and JSON; nothing else in CI ran it, and the central standard is Markdown only.

Public repo, so Actions minutes are free.

Update (.github v4.4.0): both callers moved from v4.2.1 to v4.4.0, and secret-scan.yml now calls lint-include.yml instead of lint.yml with a list of disabled linters. Its jobs are named gitleaks / lint / gitleaks. The secret-scan caller only runs on main, so its first run comes after merge.

Opened by repo-steward (findings baseline/required-file@worldtime#lint and #secret-scan, rollout batch B1). Merging this PR is the approval; close it to decline.

Part of DevSecNinja/repo-steward#45

Summary by CodeRabbit

  • Chores
    • Added automated lint checks for pull requests and pushes to the main branch.
    • Added secret scanning for main-branch pushes, weekly runs, and manual runs. Scan or reporting failures now fail the workflow.
    • Updated project formatting and validation rules, including YAML and Markdown settings.
    • Limited automatic formatting to Markdown files; other file types are no longer included in that formatting step.

Add the standard DevSecNinja lint caller and the secret-scan caller from
repo-steward's workflow-templates (DevSecNinja/repo-steward#45 and
DevSecNinja/repo-steward#140),
both on DevSecNinja/.github v4.1.0:

- .github/workflows/lint.yml: dprint, yamlfmt, yamllint, actionlint,
  gitleaks (the PR's own commits), shellcheck, shfmt, checkov, trivy and
  zizmor on pull requests and pushes to main; trivy, zizmor and checkov
  upload SARIF to code scanning. Linters only report
  (lint-fail-on-error is off).
- .github/workflows/secret-scan.yml: gitleaks over the full history on
  push to main, weekly and on demand; findings go to code scanning
  (category gitleaks/history), the log shows a count only.

The linters run from the repo's .mise.toml.
Copilot AI balanced review requested due to automatic review settings November 16, 2026 16:04
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Adds GitHub Actions workflows for linting and secret scanning. Updates editor settings and Markdown formatting, and adds YAML formatting and lint configuration.

Changes: CI workflows

Layer / File(s) Summary
Configure lint and secret scan runs
.github/workflows/lint.yml, .github/workflows/secret-scan.yml
Adds workflows that call a pinned reusable workflow. Lint runs on pull requests and pushes to main. Secret scanning runs on pushes to main, weekly, and by manual dispatch, with Gitleaks enabled and lint failures configured to fail the run.

Formatting and YAML lint configuration

Layer / File(s) Summary
Set formatting and YAML lint rules
.editorconfig, dprint.json, .yamlfmt, .yamlfmt.yaml, .yamllint.yaml
Updates editor defaults and limits dprint to Markdown. Removes .yamlfmt and adds .yamlfmt.yaml and .yamllint.yaml configurations with formatting rules and exclusions.

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Other

Merge Risk: Minimal · up to 01309

This PR adds lint and secret-scan workflows and updates formatter configuration. It does not change application behavior, and no actionable merge risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "ci: add lint and secret-scan caller workflows" matches the main change. The PR adds the lint.yml and secret-scan.yml GitHub Actions caller workflows. The title does not mention the config-s…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "ci: add lint and secret-scan caller workflows" matches the main change. The PR adds the lint.yml and secret-scan.yml GitHub Actions caller workflows. The title does not mention the config-sync changes to dprint.json, .editorconfig, and yamlfmt/yamllint files, but those are secondary to the main change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: af9ac9b1-316f-4c24-b883-7ac97faeb21e
Commits

Reviewing files that changed from the base of the PR and between b844fb0 and 013099a.

Files selected for processing: 2

  • .github/workflows/lint.yml
  • .github/workflows/secret-scan.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review records no active issues with the added lint and secret-scanning workflows.

No open issues 🎉

What changed in this PR

Adds standard DevSecNinja CI through reusable lint and secret-scan workflows pinned to v4.1.0, using tools configured in the repository’s .mise.toml.

Changes:

  • Runs reporting-only lint checks on pull requests and pushes to main, with security results uploaded to code scanning.
  • Adds full-history secret scanning on pushes to main, weekly, and on demand; scan or upload failures fail the run.
File Description
.github/​workflows/​secret-scan.yml Adds a gitleaks-only history scan with scheduled and manual triggers.
.github/​workflows/​lint.yml Adds the shared lint suite for pull requests and default-branch pushes.

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

🔍 Preview deployed: https://22a2d107.worldtime-17s.pages.dev

Updated: Tue, 17 Nov 2026 10:42:06 GMT

Adopt the central lint configs from DevSecNinja/.github config-sync/files
at v4.2.0, unchanged, as config-sync would deliver them: dprint.json and
.editorconfig replace the local copies, .yamlfmt.yaml replaces .yamlfmt,
and .yamllint.yaml is new. The central configs exclude release-please's
CHANGELOG.md and Spec Kit output, so no source file changes.

Also pin both callers to DevSecNinja/.github v4.2.1 (history findings
file as High severity).
Copilot AI balanced review requested due to automatic review settings November 16, 2026 19:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review identifies no active issues in the shared CI workflow and formatting configuration changes.

No open issues 🎉

Review effort: Balanced

Move both callers to DevSecNinja/.github v4.4.0. The secret-scan caller
now calls the thin lint-include.yml, where every linter is off unless set
to true, with only lint-gitleaks: true. It replaces the list of
lint-*: false inputs, which linters added to lint.yml later would slip
past. mise-version and lint-fail-on-error are unchanged.

The lint caller keeps lint.yml (same inputs and job names). The
secret-scan jobs are now named gitleaks / lint / gitleaks, because
lint-include.yml calls lint.yml through the self-repository ($/) syntax.
Copilot AI balanced review requested due to automatic review settings November 17, 2026 10:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the shared linting, secret-scanning, and formatting changes.

No open issues 🎉

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the shared lint, secret-scanning, and formatting configuration changes.

No open issues 🎉

Review effort: Balanced

@DevSecNinja
DevSecNinja merged commit 1bcadaf into main Nov 17, 2026
31 of 33 checks passed
@DevSecNinja
DevSecNinja deleted the steward/lint-ci branch November 17, 2026 16:21
@DevSecNinja DevSecNinja mentioned this pull request Nov 18, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants