Repository navigation
ci: add lint and secret-scan caller workflows - #61
Conversation
Add the standard DevSecNinja lint caller and the secret-scan caller from repo-steward's workflow-templates (DevSecNinja/repo-steward#45 and DevSecNinja/repo-steward#140), both on DevSecNinja/.github v4.1.0: - .github/workflows/lint.yml: dprint, yamlfmt, yamllint, actionlint, gitleaks (the PR's own commits), shellcheck, shfmt, checkov, trivy and zizmor on pull requests and pushes to main; trivy, zizmor and checkov upload SARIF to code scanning. Linters only report (lint-fail-on-error is off). - .github/workflows/secret-scan.yml: gitleaks over the full history on push to main, weekly and on demand; findings go to code scanning (category gitleaks/history), the log shows a count only. The linters run from the repo's .mise.toml.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
There was a problem hiding this comment.
🟢 Approval recommended
The review records no active issues with the added lint and secret-scanning workflows.
No open issues 🎉
What changed in this PR
Adds standard DevSecNinja CI through reusable lint and secret-scan workflows pinned to v4.1.0, using tools configured in the repository’s .mise.toml.
Changes:
- Runs reporting-only lint checks on pull requests and pushes to
main, with security results uploaded to code scanning. - Adds full-history secret scanning on pushes to
main, weekly, and on demand; scan or upload failures fail the run.
| File | Description |
|---|---|
.github/workflows/secret-scan.yml |
Adds a gitleaks-only history scan with scheduled and manual triggers. |
.github/workflows/lint.yml |
Adds the shared lint suite for pull requests and default-branch pushes. |
Review effort: Balanced
|
🔍 Preview deployed: https://22a2d107.worldtime-17s.pages.dev Updated: Tue, 17 Nov 2026 10:42:06 GMT |
Adopt the central lint configs from DevSecNinja/.github config-sync/files at v4.2.0, unchanged, as config-sync would deliver them: dprint.json and .editorconfig replace the local copies, .yamlfmt.yaml replaces .yamlfmt, and .yamllint.yaml is new. The central configs exclude release-please's CHANGELOG.md and Spec Kit output, so no source file changes. Also pin both callers to DevSecNinja/.github v4.2.1 (history findings file as High severity).
Move both callers to DevSecNinja/.github v4.4.0. The secret-scan caller now calls the thin lint-include.yml, where every linter is off unless set to true, with only lint-gitleaks: true. It replaces the list of lint-*: false inputs, which linters added to lint.yml later would slip past. mise-version and lint-fail-on-error are unchanged. The lint caller keeps lint.yml (same inputs and job names). The secret-scan jobs are now named gitleaks / lint / gitleaks, because lint-include.yml calls lint.yml through the self-repository ($/) syntax.
Adds the standard DevSecNinja lint and secret-scan CI, from repo-steward's workflow templates, both on DevSecNinja/.github v4.4.0.
.github/workflows/lint.ymlruns on pull requests and on pushes tomain. It runs dprint, yamlfmt, yamllint, actionlint, gitleaks, shellcheck, shfmt, checkov, trivy and zizmor, one job per linter. gitleaks on a PR scans only that PR's commits. trivy, zizmor and checkov upload SARIF to code scanning. Linters only report:lint-fail-on-erroris off, so a finding never blocks a merge..github/workflows/secret-scan.ymlcallslint-include.yml, where every linter is off unless enabled, with onlylint-gitleaks: true. It runs gitleaks alone over the full git history on push tomain, weekly (Mon 05:23 UTC) and on demand, so new gitleaks rules re-check old commits. Findings go to code scanning (categorygitleaks/history), where only people with write access see them. The public log shows a count only..mise.toml, which Renovate keeps current.Lint debt: adopts the central lint configs from DevSecNinja/.github
config-sync/filesat v4.2.0, unchanged, as config-sync would deliver them:dprint.jsonand.editorconfigreplace the local copies,.yamlfmt.yamlreplaces.yamlfmt, and.yamllint.yamlis new. The central configs exclude release-please'sCHANGELOG.mdand Spec Kit output, so no source file changes. The localdprint.jsonalso formatted TS, CSS, HTML and JSON; nothing else in CI ran it, and the central standard is Markdown only.Public repo, so Actions minutes are free.
Update (.github v4.4.0): both callers moved from v4.2.1 to v4.4.0, and
secret-scan.ymlnow callslint-include.ymlinstead oflint.ymlwith a list of disabled linters. Its jobs are namedgitleaks / lint / gitleaks. The secret-scan caller only runs onmain, so its first run comes after merge.Opened by repo-steward (findings
baseline/required-file@worldtime#lintand#secret-scan, rollout batch B1). Merging this PR is the approval; close it to decline.Part of DevSecNinja/repo-steward#45
Summary by CodeRabbit