Skip to content

fix(a11y): let the brand link's name include its visible text - #63

Merged
DevSecNinja merged 2 commits into
mainfrom
steward/a11y-brand-label
Nov 18, 2026
Merged

DevSecNinja merged 2 commits into
mainfrom
steward/a11y-brand-label

Conversation

@DevSecNinja

@DevSecNinja DevSecNinja commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

What

Removes the redundant aria-label from the header brand link in src/components/AppHeader.tsx.
The link's accessible name now comes from its visible text ("Worldtime One moment. Every time
zone."). The decorative mark stays aria-hidden. No visual change.

Why

axe-core 4.14 adds a serious label-content-name-mismatch finding (WCAG 2.5.3 Label in Name) on
this link: aria-label="Worldtime" overrides a visible name that also includes the tagline. That
fails the accessibility e2e test (tests/e2e/share-event.spec.ts) on all three browsers in the
Renovate axe-core update, #57
(failing run).

The rule only applies to elements with an author-supplied aria-label/aria-labelledby, so
dropping the label resolves it rather than suppressing it. No test looks the link up by the name
"Worldtime".

After merge

Once this merges, Renovate's next rebase of #57 should turn its "Build and validate site" check
green, because axe-core 4.14 no longer finds the violation.

Closes #62

Summary by CodeRabbit

  • Accessibility
    • The brand link no longer announces the translated app name to assistive technologies. Language, time-format, and theme controls are unchanged.

axe-core 4.14 reports label-content-name-mismatch (WCAG 2.5.3) on the
header brand link: its aria-label "Worldtime" omits the visible tagline.
Drop the redundant aria-label so the name comes from the visible text.

Refs #62

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 18, 2026 15:54
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 49 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0609467f-0db8-4dd4-9de7-6c4dad580ec0
Commits

Reviewing files that changed from the base of the PR and between 44c0217 and 2074fd3.

Files selected for processing: 1

  • src/components/AppHeader.tsx

No actionable comments were generated in the recent review.

Walkthrough

The brand link in AppHeader no longer sets an aria-label. Its visible text provides the link’s accessible name.

Changes: Brand link accessible name

Layer / File(s) Summary
Remove brand link aria-label
src/components/AppHeader.tsx
The brand link no longer sets an aria-label to the translated app name. Its accessible name comes from its visible text.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: Minimal · previous review 44c02

The header brand link now takes its accessible name from its visible text, including the tagline, with no visual change. No concrete merge risk was found.

Pre-merge checks: Passed 2 · Inconclusive 2

Failed Failed checks: 2 inconclusive

Check name Status Explanation Resolution
Linked Issues check Inconclusive Issue #62 requires removing the redundant aria-label from the brand link in src/components/AppHeader.tsx, keeping the decorative mark aria-hidden, and making no visual change. The AI-generated summary… Provide the readable diff or the head file content for src/components/AppHeader.tsx (the brand link markup). Confirm that the brand link has no aria-label, that the brand-mark span keeps aria-hidden="true", and that the only change is the r…
Out of Scope Changes check Inconclusive The AI-generated summary lists src/components/AppHeader.tsx as the only changed file and describes a single behavioral change, the removal of the brand link aria-label. No unrelated behavior change is… Provide the readable whole-PR diff from the merge base to head, or the head and base contents of src/components/AppHeader.tsx. Confirm that the changed hunks are limited to the brand link aria-label removal, and that the line count is expla…
Passed Passed checks: 2 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: the brand link's accessible name now comes from its visible text, which the diff supports by removing the aria-label from AppHeader.tsx. The fix(a11y) prefix matches t…
Full details: Title check

Explanation

The title names the main change: the brand link's accessible name now comes from its visible text, which the diff supports by removing the aria-label from AppHeader.tsx. The fix(a11y) prefix matches the accessibility purpose in the objectives and linked issue #62. The title is specific and concise, and it does not describe unrelated work.

Full details: Linked Issues check

Explanation

Issue #62 requires removing the redundant aria-label from the brand link in src/components/AppHeader.tsx, keeping the decorative mark aria-hidden, and making no visual change. The AI-generated summary states that the brand link no longer has an aria-label, and that the language, time-format, and theme controls are unchanged. That supports the removal requirement. The text diff for src/components/AppHeader.tsx could not be read because the changed blobs are missing from the checkout, so the final markup could not be confirmed. The aria-hidden mark and the no-visual-change requirement are therefore not verified from source. The summary also reports +57/-57 lines for one attribute removal, which the diff would need to explain. The claim that the e2e test in tests/e2e/share-event.spec.ts passes is not verified in this review. No coding requirement in #62 calls for a new automated test.

Resolution

Provide the readable diff or the head file content for src/components/AppHeader.tsx (the brand link markup). Confirm that the brand link has no aria-label, that the brand-mark span keeps aria-hidden="true", and that the only change is the removed attribute. Explain the +57/-57 line count, for example as line-ending or whitespace churn. Provide the result of tests/e2e/share-event.spec.ts on head, or confirm that the run passes.

Full details: Out of Scope Changes check

Explanation

The AI-generated summary lists src/components/AppHeader.tsx as the only changed file and describes a single behavioral change, the removal of the brand link aria-label. No unrelated behavior change is reported. The reported +57/-57 line count is larger than one attribute removal would produce. Without a readable diff, this review cannot rule out unrelated edits, such as whole-file whitespace or line-ending changes, or changes to other controls in the same file. The changed-file list for the whole PR (merge base to head) also could not be confirmed against the diff.

Resolution

Provide the readable whole-PR diff from the merge base to head, or the head and base contents of src/components/AppHeader.tsx. Confirm that the changed hunks are limited to the brand link aria-label removal, and that the line count is explained by line-ending or whitespace changes that do not alter behavior.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: efec8b05-1fdb-4250-aeee-fb199f404461
Commits

Reviewing files that changed from the base of the PR and between 1bcadaf and 44c0217.

Files selected for processing: 1

  • src/components/AppHeader.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the update to use the brand link’s visible, localized text as its accessible name.

No open issues 🎉

What changed in this PR

Updates the shared header’s brand link so its accessible name comes from its visible, localized text. This addresses #62 and the label-in-name failure reported with the axe-core update in #57.

Changes:

  • Removes the brand link’s redundant aria-label, allowing the visible tagline to contribute to its accessible name.
  • Preserves the decorative mark’s aria-hidden attribute and leaves the visual appearance unchanged.
File Description
src/​components/​AppHeader.tsx Removes the brand link’s explicit label so visible text supplies its accessible name.

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 18, 2026 16:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The header brand-link accessible-name change has no active review issues.

No open issues 🎉

Review effort: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Preview deployed: https://2e38a372.worldtime-17s.pages.dev

Updated: Wed, 18 Nov 2026 16:11:28 GMT

@DevSecNinja
DevSecNinja merged commit ed0e70e into main Nov 18, 2026
31 checks passed
@DevSecNinja
DevSecNinja deleted the steward/a11y-brand-label branch November 18, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(a11y): brand link accessible name omits its visible tagline

2 participants