Repository navigation
fix(a11y): let the brand link's name include its visible text - #63
Conversation
axe-core 4.14 reports label-content-name-mismatch (WCAG 2.5.3) on the header brand link: its aria-label "Worldtime" omits the visible tagline. Drop the redundant aria-label so the name comes from the visible text. Refs #62 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 49 minutes. View limit details
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the update to use the brand link’s visible, localized text as its accessible name.
No open issues 🎉
What changed in this PR
Updates the shared header’s brand link so its accessible name comes from its visible, localized text. This addresses #62 and the label-in-name failure reported with the axe-core update in #57.
Changes:
- Removes the brand link’s redundant
aria-label, allowing the visible tagline to contribute to its accessible name. - Preserves the decorative mark’s
aria-hiddenattribute and leaves the visual appearance unchanged.
| File | Description |
|---|---|
src/components/AppHeader.tsx |
Removes the brand link’s explicit label so visible text supplies its accessible name. |
Review effort: Balanced
|
🔍 Preview deployed: https://2e38a372.worldtime-17s.pages.dev Updated: Wed, 18 Nov 2026 16:11:28 GMT |
What
Removes the redundant
aria-labelfrom the header brand link insrc/components/AppHeader.tsx.The link's accessible name now comes from its visible text ("Worldtime One moment. Every time
zone."). The decorative mark stays
aria-hidden. No visual change.Why
axe-core 4.14 adds a serious
label-content-name-mismatchfinding (WCAG 2.5.3 Label in Name) onthis link:
aria-label="Worldtime"overrides a visible name that also includes the tagline. Thatfails the accessibility e2e test (
tests/e2e/share-event.spec.ts) on all three browsers in theRenovate axe-core update, #57
(failing run).
The rule only applies to elements with an author-supplied
aria-label/aria-labelledby, sodropping the label resolves it rather than suppressing it. No test looks the link up by the name
"Worldtime".
After merge
Once this merges, Renovate's next rebase of #57 should turn its "Build and validate site" check
green, because axe-core 4.14 no longer finds the violation.
Closes #62
Summary by CodeRabbit