[DEVOPS-4655] feat(administrative-roles): add administrative roles and role assignments - #43
Merged
Dion Gionet Mallet (dion-gionet) merged 2 commits intoSep 3, 2026
Conversation
…d role assignments
|
🤖 You did not bump the version, a release won't be created |
Copilot started reviewing on behalf of
Dion Gionet Mallet (dion-gionet)
September 2, 2026 20:37
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Array-shaped v3 error responses can bypass result validation, and the README attribution is unintentionally removed.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds DVLS 2026.3 administrative-role and role-assignment support.
Changes:
- Adds role and assignment APIs, models, filters, and pagination.
- Defines administrative permissions, scopes, actions, and built-in roles.
- Adds response helpers, tests, client wiring, and documentation.
File summaries
| File | Description |
|---|---|
v3.go |
Handles v3 envelopes and paging. |
utils.go |
Adds JSON-value detection. |
README.md |
Documents version requirements. |
mock_test.go |
Adds shared test IDs. |
authentication.go |
Exposes new client services. |
administrativerolescopetype_string.go |
Generates scope strings. |
administrativerolememberaction_string.go |
Generates action strings. |
administrativeroleassigneetype_string.go |
Generates assignee strings. |
administrativepermission_string.go |
Generates permission strings. |
administrative_types.go |
Defines enums and built-in roles. |
administrative_roles.go |
Implements role retrieval APIs. |
administrative_roles_unit_test.go |
Tests role APIs. |
administrative_roles_test.go |
Adds integration coverage. |
administrative_role_assignments.go |
Implements assignment APIs. |
administrative_role_assignments_unit_test.go |
Tests assignment APIs. |
administrative_permissions.go |
Defines permission constants. |
Review details
Files not reviewed (4)
- administrativepermission_string.go: Generated file
- administrativeroleassigneetype_string.go: Generated file
- administrativerolememberaction_string.go: Generated file
- administrativerolescopetype_string.go: Generated file
- Files reviewed: 12/16 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Copilot resolve the merge conflicts in this pull request |
Copilot started work on behalf of
Dion Gionet Mallet (dion-gionet)
September 3, 2026 14:56
View session
…administrative-roles # Conflicts: # authentication.go # mock_test.go # utils.go Co-authored-by: dion-gionet <29441318+dion-gionet@users.noreply.github.com>
Resolved the merge conflicts with |
|
🤖 You did not bump the version, a release won't be created |
Dion Gionet Mallet (dion-gionet)
deleted the
devops/DEVOPS-4655-administrative-roles
branch
September 3, 2026 15:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.