Skip to content

[DEVOPS-4655] feat(entries): add entry and folder permissions management - #44

Merged
Dion Gionet Mallet (dion-gionet) merged 2 commits into
masterfrom
devops/DEVOPS-4655-entry-permissions
Sep 3, 2026
Merged

Dion Gionet Mallet (dion-gionet) merged 2 commits into
masterfrom
devops/DEVOPS-4655-entry-permissions

Conversation

@dion-gionet

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

🤖 You did not bump the version, a release won't be created ⚠️

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Null response data can panic during updates, and permission retrieval inconsistently accepts an empty entry ID.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds entry and folder permission management to the DVLS client.

Changes:

  • Introduces permission models, enums, and generated string methods.
  • Adds permission retrieval and replacement while preserving unrelated fields.
  • Wires the service into Entries and adds unit/integration coverage.
File summaries
File Description
authentication.go Initializes the permissions service.
dvlstypes.go Defines permission-related enums.
entries.go Exposes the permissions service.
entry_permissions.go Implements permission retrieval, validation, and updates.
entry_permissions_test.go Adds folder permission integration coverage.
entry_permissions_unit_test.go Tests serialization, validation, and folder handling.
mock_test.go Adds a shared test entry ID.
securityroleoverride_string.go Adds generated override names.
securityroleright_string.go Adds generated permission-right names.
utils.go Adds a raw JSON presence helper.
Review details

Files not reviewed (2)

  • securityroleoverride_string.go: Generated file
  • securityroleright_string.go: Generated file
  • Files reviewed: 8/10 changed files
  • Comments generated: 2
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread entry_permissions.go
Comment thread entry_permissions.go
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

🤖 You did not bump the version, a release won't be created ⚠️

@dion-gionet
Dion Gionet Mallet (dion-gionet) merged commit 3e45e3f into master Sep 3, 2026
2 checks passed
@dion-gionet
Dion Gionet Mallet (dion-gionet) deleted the devops/DEVOPS-4655-entry-permissions branch September 3, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants