[DEVOPS-4655] feat(entries): add entry and folder permissions management - #44
Merged
Dion Gionet Mallet (dion-gionet) merged 2 commits intoSep 3, 2026
Conversation
|
🤖 You did not bump the version, a release won't be created |
Copilot started reviewing on behalf of
Dion Gionet Mallet (dion-gionet)
September 2, 2026 20:38
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Null response data can panic during updates, and permission retrieval inconsistently accepts an empty entry ID.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds entry and folder permission management to the DVLS client.
Changes:
- Introduces permission models, enums, and generated string methods.
- Adds permission retrieval and replacement while preserving unrelated fields.
- Wires the service into
Entriesand adds unit/integration coverage.
File summaries
| File | Description |
|---|---|
authentication.go |
Initializes the permissions service. |
dvlstypes.go |
Defines permission-related enums. |
entries.go |
Exposes the permissions service. |
entry_permissions.go |
Implements permission retrieval, validation, and updates. |
entry_permissions_test.go |
Adds folder permission integration coverage. |
entry_permissions_unit_test.go |
Tests serialization, validation, and folder handling. |
mock_test.go |
Adds a shared test entry ID. |
securityroleoverride_string.go |
Adds generated override names. |
securityroleright_string.go |
Adds generated permission-right names. |
utils.go |
Adds a raw JSON presence helper. |
Review details
Files not reviewed (2)
- securityroleoverride_string.go: Generated file
- securityroleright_string.go: Generated file
- Files reviewed: 8/10 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
🤖 You did not bump the version, a release won't be created |
Richard Boisvert (rbstp)
approved these changes
Sep 3, 2026
Dion Gionet Mallet (dion-gionet)
deleted the
devops/DEVOPS-4655-entry-permissions
branch
September 3, 2026 14:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.