Skip to content

Write the DIALS file format attributes on reflection tables - #173

Merged
dimitrivlachos merged 2 commits into
mainfrom
dials-hdf5
Nov 16, 2026
Merged

dimitrivlachos merged 2 commits into
mainfrom
dials-hdf5

Conversation

@dimitrivlachos

@dimitrivlachos dimitrivlachos commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

This PR makes the reflection files fast-feedback-service writes
readable by DIALS 3.31. Since dials/dials#3255 (02bb48d), the
DIALS reflection table reader refuses any HDF5 file whose root
lacks a file_type attribute equal to "dials_processed_data" and a
file_version of 1 (check). Nothing we write carries either attribute,
so the downstream pipeline on the cluster has been held at an older DIALS
to read our integrated.refl; this lets it move back to the latest release.
Every C++ writer goes through dx2's ReflectionTable::write, which now
writes both attributes (dials/dx2#67), so that half of the fix is a submodule
bump. The stills indexer writes its own file with h5py and gets the same two
attributes by hand.

Changes

@dimitrivlachos
dimitrivlachos merged commit 3dd007e into main Nov 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants