Repository navigation
Write the DIALS file format attributes on reflection tables - #173
Merged
Merged
Conversation
jbeilstenedmands
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the reflection files fast-feedback-service writes
readable by DIALS 3.31. Since dials/dials#3255 (02bb48d), the
DIALS reflection table reader refuses any HDF5 file whose root
lacks a
file_typeattribute equal to"dials_processed_data"and afile_versionof 1 (check). Nothing we write carries either attribute,so the downstream pipeline on the cluster has been held at an older DIALS
to read our
integrated.refl; this lets it move back to the latest release.Every C++ writer goes through dx2's
ReflectionTable::write, which nowwrites both attributes (dials/dx2#67), so that half of the fix is a submodule
bump. The stills indexer writes its own file with h5py and gets the same two
attributes by hand.
Changes
Write the DIALS file format attributes on reflection tables dials/dx2#67
for the file format attributes.
ssx_index.pywritesfile_typeandfile_versionon the fileroot. h5py stores a Python
strandintas a scalarvariable-length string and a scalar int64, the types the DIALS check
compares against and the same ones dx2 writes.