Docs: Adding foundation section - Colours#220
Conversation
075dc35 to
73fc711
Compare
db21b01 to
710c8d5
Compare
2b42962 to
0146d8e
Compare
zoharma
changed the title
a296765 to
24963e6
Compare
6ab5cbc to
6d711b2
Compare
- Adding Foundation section with colours page
- Adding theme colours page
- Added views for both light and dark modes
- Adding the relevant css and ability to do so.
- Remove typography and icons (to be pushed to another PR)
- Remove :root from [data-mode="${mode}"] so that the mode can be used in any container
The merge-base changed after approval.
|
Just realised: For this ticket - now that data-mode is supported on any container rather than just :root, worth flagging: ThemeProvider's flicker-suppression MutationObserver on 251 only watches document.documentElement, so nested containers using their own data-mode won't get transition suppression. Is this expected/acceptable? |
|
@NKatti2011 that's a good point and it's worth exploring. The main reason for this change here is so that we can show dark mode elements in the docs in Storybook (set in light mode). There might be other usages for it in the future, for components to have their own dark/light mode settings (such as code-views and editors), but that may require further exploration. |
|
@NKatti2011 Have added it as issue #258. Could we approve this? |
NKatti2011
left a comment
NKatti2011
left a comment
There was a problem hiding this comment.
Am approving but as discussed the removal of data-mode from root may cause downstream issues re flicker suppression in another PR.
The merge-base changed after approval.
The merge-base changed after approval.
7fad52b to
9af1896
Compare
3 participants
Introduced Foundation section with:
1.1 Theme Colours
Changes:
:rootfromdata-mode="{mode}"so that the mode can be used in any container