Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…VE-SC-009) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
gbolly122
force-pushed
the
feat/contract-budget-gate-684
branch
from
October 23, 2026 17:37
255284a to
81ced40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a fail-closed budget gate for the canonical V2 operations: claim, commit, reveal, dispute, appeal, settlement, rewards, governance and pause.
config/contract-budgets.json: reviewed per-operation gas ceiling, ABI calldata model, worst-case scenario, Optimism fee context (no price promises) and reviewedoverrides.config/contract-budget-baseline.json: last reviewed values. Any increase needs a matching override with rationale and reviewer; stale overrides fail.scripts/check-contract-budgets.mjs: enforces gas ceilings againstgas-budgets.json, derives worst-case calldata from the declared bounds (oversized-calldata boundary and policy cap), checks size budgets stay within EIP-170, and writes evidence (commit, input SHA-256, toolchain pins) todeployments/releases/contract-budget-evidence.json.docs/CONTRACT_BUDGETS.mddocuments the process.No storage layout, role, pause, upgrade or economic behavior is changed.
Testing
node --test test/scripts/check-contract-budgets.test.mjs(11 tests: missing operation, gas over budget, oversized calldata, unknown bound, size over network limit, unexplained regression, explicit budget override, stale override, missing baseline) andnode scripts/check-contract-budgets.mjsboth pass locally.Not covered
I did not run Foundry or Hardhat locally. Measured gas per operation still comes from the existing Foundry scenario snapshots (
check:gas:sc064); this gate checks the reviewed budgets and derived bounds offline.Closes #684
🤖 Generated with Claude Code