Prevent blocked profile persistence from stopping peer connections - #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learning a peer could block all new peer connections:
AddPeerheld the registry mutex while saving to FlatSQL, andInterceptUpgradedneeded that mutex to record the connection. The CelesTrak live goroutine dump reproduced this chain behind background record hydration.All registry mutations now release the memory lock before persistence. Admin writes and background statistics share a separate persistence mutex and snapshot the latest state only after acquiring it, preventing older snapshots from overwriting newer updates. Failed writes still return
ErrNotPersisted.Validation: the regression using two real libp2p hosts fails before this change and passes after it while persistence is deliberately blocked. The peers suite and focused race check pass; the regression also passes in Linux/amd64 Docker.