Skip to content

ci: keep the workflow callers in step with the templates - #62

Closed
soydiloreto wants to merge 3 commits into
mainfrom
ci/61-org-workflow-callers
Closed

soydiloreto wants to merge 3 commits into
mainfrom
ci/61-org-workflow-callers

Conversation

@soydiloreto

Copy link
Copy Markdown
Member

📝 What changes

.github/workflows/issues.yml, .github/workflows/plugin-checks-wp.yml as workflow-templates/issues.yml has them, with this repository's own values and jobs kept.

💡 Why

A job a template gains reaches every repository only through its callers; the daily drift check (DiluxOne/.github, scripts/sync-repos.py check) found these out of step.

Closes #61

🤖 AI-generated · scripts/sync-repos.py

@dilux-bot dilux-bot Bot mentioned this pull request Nov 7, 2026
@dilux-bot

dilux-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

@soydiloreto: accept it (the accepted label) or say why not #62

🤖 AI-generated · Claude Opus 5.5 (Anthropic)

@dilux-bot

dilux-bot Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

The pull request's board

State
Waits on soydiloreto: accept it (the accepted label) or say why not (link)

🤖 AI-generated · Claude Opus 5.5 (Anthropic)

@dilux-bot dilux-bot Bot added risk:high Set by the Claude review complexity:medium Set by the Claude review type:ci The kind of change, read from the diff by the Claude review labels Nov 7, 2026
@dilux-bot

dilux-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Claude review · risk high · complexity medium · type ci

1 to fix (1 major)

Syncs issues.yml (new claim, waiting and autopilot-sweep jobs, issue_comment and pull_request_target triggers, per-job if guards) and adds plugin-checks-wp.yml. The new plugin-checks-wp.yml caller passes a slug and version constant that do not match this plugin (diluxone-sandbox, DILUXONE_SANDBOX_VERSION), so its checks would fail or check the wrong thing. The description says the files match the template "with this repository's own values", but these two values are not this repository's. It also leaves unsaid that plugin-checks-wp.yml is a new file and that issues.yml now runs on pull_request_target with inherited secrets. The pull_request_target jobs only read metadata and check out no pull request code, as their header comments state; I could not check that against the called workflows. The @v7 pins on the organisation's own reusable workflows follow the template; I did not check the templates themselves.

✍️ The description does not match the code (see the summary): no auto-merge until it does.

  • major .github/workflows/plugin-checks-wp.yml:487: slug and version-constant do not match this plugin

Policy floor: high (touches high-risk paths: .github/workflows/issues.yml, .github/workflows/plugin-checks-wp.yml). Reviewed 216b897 (whole pull request; review 1 of 5 automatic). Author trusted for auto-merge: true.

🤖 AI review · claude-sonnet-5-5 (Anthropic) · $0.20, 5 turns

Comment thread .github/workflows/plugin-checks-wp.yml Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

major: slug and version-constant do not match this plugin

The caller passes slug: sandbox-wordpress-plugin and version-constant: SANDBOX_WORDPRESS_PLUGIN_VERSION (repo-name defaults). The plugin is diluxone-sandbox.php, with Text Domain diluxone-sandbox and define( 'DILUXONE_SANDBOX_VERSION', '0.2.0' ). release-wp.yml in this repository already uses slug: diluxone-sandbox and version-constant: DILUXONE_SANDBOX_VERSION. With the wrong values, the shared checks look for a main file, text domain and constant that do not exist. The version alignment, text-domain and Plugin Check steps fail on every pull request, push and weekly run, or check the wrong thing. Set slug: diluxone-sandbox and version-constant: DILUXONE_SANDBOX_VERSION. If sync-repos.py callers generates these from repos.yml, fix the entry in repos.yml in DiluxOne/.github too, or the next sync reverts this.

🤖 AI review · claude-sonnet-5-5 (Anthropic)

The sandbox has no package.json and no composer test scripts, so every check of plugin-checks-wp.yml fails on it. The caller goes in once the plugin can run the battery.

AI-assisted: yes

Assisted-by: Claude Opus 5.5 (Anthropic)
@dilux-bot

dilux-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

@soydiloreto: accept it (the accepted label) or say why not #62

🤖 AI-generated · Claude Opus 5.5 (Anthropic)

@soydiloreto

Copy link
Copy Markdown
Member Author

Closing: this repository cannot run plugin-checks-wp.yml yet, and with that file dropped the change no longer matches the org-sync lane's acceptance. The callers sync is fixed in DiluxOne/.github#681; its next run opens this again with what applies here.

🤖 AI-generated · Claude Opus 5.5 (Anthropic)

@soydiloreto soydiloreto closed this Nov 7, 2026
@soydiloreto
soydiloreto deleted the ci/61-org-workflow-callers branch November 7, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity:medium Set by the Claude review risk:high Set by the Claude review type:ci The kind of change, read from the diff by the Claude review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep the workflow callers in step with the organisation's templates

1 participant