Skip to content

ci: keep the workflow callers in step with the templates - #64

Open
dilux-bot[bot] wants to merge 2 commits into
mainfrom
ci/63-org-workflow-callers
Open

dilux-bot[bot] wants to merge 2 commits into
mainfrom
ci/63-org-workflow-callers

Conversation

@dilux-bot

@dilux-bot dilux-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

📝 What changes

.github/workflows/issues.yml, .github/workflows/plugin-checks-wp.yml as workflow-templates/issues.yml has them, with this repository's own values and jobs kept.

💡 Why

A job a template gains reaches every repository only through its callers; the daily drift check (DiluxOne/.github, scripts/sync-repos.py check) found these out of step.

Closes #63

🤖 AI-generated · scripts/sync-repos.py

@dilux-bot
dilux-bot Bot requested a review from soydiloreto as a code owner November 7, 2026 09:47
@dilux-bot dilux-bot Bot mentioned this pull request Nov 7, 2026
@dilux-bot dilux-bot Bot added risk:high Set by the Claude review complexity:medium Set by the Claude review type:ci The kind of change, read from the diff by the Claude review labels Nov 7, 2026
@dilux-bot

dilux-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

Claude review · risk high · complexity medium · type ci · blocking

1 to fix (1 major)

First review: the two callers match their templates apart from the repository's own values, but the plugin-checks-wp.yml values do not match this plugin. The description says only "as the template has them". It leaves out that plugin-checks-wp.yml is a new file and that issues.yml gains the issue_comment and pull_request_target triggers. It also leaves out the new claim, waiting and autopilot-sweep jobs and the Claude secrets (CLAUDE_CODE_OAUTH_TOKEN, ANTHROPIC_API_KEY) now passed to accepted; claim runs with secrets: inherit on pull_request_target. Minor: issues.yml gets the new jobs and their inline comments but not the template's header paragraph describing claims, waiting and autopilot-sweep (template lines 7-15), so the header is stale. Minor: support-url in issues.yml is the repository's issues page, a repository-owned value kept on purpose. I did not run the checks; the version-constant and main-file mismatch is read from .github/workflows/release-wp.yml, diluxone-sandbox.php and the called workflow's MAIN logic.

✍️ The description does not match the code (see the summary): no auto-merge until it does.

  • major .github/workflows/plugin-checks-wp.yml:43: slug and version-constant do not match this plugin (main file is diluxone-sandbox.php)

Policy floor: high (touches high-risk paths: .github/workflows/issues.yml, .github/workflows/plugin-checks-wp.yml). Reviewed 9b96c2b (whole pull request; review 1 of 5 automatic). Author trusted for auto-merge: false.

🤖 AI review · claude-sonnet-5-5 (Anthropic) · $0.12, 8 turns

checks: read # and the checks of its head
uses: DiluxOne/.github/.github/workflows/plugin-checks-wp.yml@v7
with:
slug: sandbox-wordpress-plugin

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

major: slug and version-constant do not match this plugin (main file is diluxone-sandbox.php)

The caller passes slug: sandbox-wordpress-plugin and version-constant: SANDBOX_WORDPRESS_PLUGIN_VERSION. The plugin's main file is diluxone-sandbox.php, its text domain and the slug in release-wp.yml are diluxone-sandbox, and its constant is DILUXONE_SANDBOX_VERSION. The called plugin-checks-wp.yml derives the main file as <slug>.php (MAIN: format('{0}.php', inputs.slug)) when main-file is not set. It then runs grep on sandbox-wordpress-plugin.php, which does not exist, and the header and version-alignment step fails. The release-marker check reads the wrong constant too. Every pull request to this repository, and the weekly run, would fail the checks job. Fix: set slug: diluxone-sandbox and version-constant: DILUXONE_SANDBOX_VERSION, matching release-wp.yml. Because sync-repos.py callers writes these values from repos.yml (default slug is the repository name), also give this repository its slug and constant in repos.yml in DiluxOne/.github, or the daily drift check will write the wrong values back.

🤖 AI review · claude-sonnet-5-5 (Anthropic)

@dilux-bot

dilux-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

@soydiloreto: accept it (the accepted label) or say why not #64

🤖 AI-generated · Claude Opus 5.5 (Anthropic)

@dilux-bot

dilux-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

The pull request's board

State
Waits on soydiloreto: accept it (the accepted label) or say why not (link)

🤖 AI-generated · Claude Opus 5.5 (Anthropic)

@soydiloreto

Copy link
Copy Markdown
Member

Not as is: the plugin is diluxone-sandbox (diluxone-sandbox.php). Use slug diluxone-sandbox and constant DILUXONE_SANDBOX_VERSION, as the review says.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity:medium Set by the Claude review risk:high Set by the Claude review type:ci The kind of change, read from the diff by the Claude review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep the workflow callers in step with the organisation's templates

1 participant