Repository navigation
ci: keep the workflow callers in step with the templates - #64
dilux-bot[bot] wants to merge 2 commits into
Conversation
Claude review · risk high · complexity medium · type ci · blocking1 to fix (1 major) First review: the two callers match their templates apart from the repository's own values, but the
Policy floor: high (touches high-risk paths: .github/workflows/issues.yml, .github/workflows/plugin-checks-wp.yml). Reviewed 9b96c2b (whole pull request; review 1 of 5 automatic). Author trusted for auto-merge: false. 🤖 AI review · claude-sonnet-5-5 (Anthropic) · $0.12, 8 turns |
| checks: read # and the checks of its head | ||
| uses: DiluxOne/.github/.github/workflows/plugin-checks-wp.yml@v7 | ||
| with: | ||
| slug: sandbox-wordpress-plugin |
There was a problem hiding this comment.
major: slug and version-constant do not match this plugin (main file is diluxone-sandbox.php)
The caller passes slug: sandbox-wordpress-plugin and version-constant: SANDBOX_WORDPRESS_PLUGIN_VERSION. The plugin's main file is diluxone-sandbox.php, its text domain and the slug in release-wp.yml are diluxone-sandbox, and its constant is DILUXONE_SANDBOX_VERSION. The called plugin-checks-wp.yml derives the main file as <slug>.php (MAIN: format('{0}.php', inputs.slug)) when main-file is not set. It then runs grep on sandbox-wordpress-plugin.php, which does not exist, and the header and version-alignment step fails. The release-marker check reads the wrong constant too. Every pull request to this repository, and the weekly run, would fail the checks job. Fix: set slug: diluxone-sandbox and version-constant: DILUXONE_SANDBOX_VERSION, matching release-wp.yml. Because sync-repos.py callers writes these values from repos.yml (default slug is the repository name), also give this repository its slug and constant in repos.yml in DiluxOne/.github, or the daily drift check will write the wrong values back.
🤖 AI review · claude-sonnet-5-5 (Anthropic)
|
@soydiloreto: accept it (the 🤖 AI-generated · Claude Opus 5.5 (Anthropic) |
|
The pull request's board
🤖 AI-generated · Claude Opus 5.5 (Anthropic) |
|
Not as is: the plugin is diluxone-sandbox (diluxone-sandbox.php). Use slug |
📝 What changes
.github/workflows/issues.yml, .github/workflows/plugin-checks-wp.yml as workflow-templates/issues.yml has them, with this repository's own values and jobs kept.
💡 Why
A job a template gains reaches every repository only through its callers; the daily drift check (DiluxOne/.github, scripts/sync-repos.py check) found these out of step.
Closes #63
🤖 AI-generated · scripts/sync-repos.py