Clip SVG replaced content, except SVGs that blend with their backdrop - #634
Open
nicoburns wants to merge 1 commit into
Open
Clip SVG replaced content, except SVGs that blend with their backdrop#634nicoburns wants to merge 1 commit into
nicoburns wants to merge 1 commit into
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
staging-devin-ai-integration
Bot
changed the base branch from
main
to
devin/1786154184-item-is-replaced
August 8, 2026 01:57
staging-devin-ai-integration
Bot
force-pushed
the
devin/1786151607-block-replaced-sizing
branch
from
August 8, 2026 01:57
32505e0 to
9f6188e
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1786151607-block-replaced-sizing
branch
from
August 8, 2026 02:12
9f6188e to
9e02773
Compare
staging-devin-ai-integration
Bot
changed the base branch from
devin/1786154184-item-is-replaced
to
main
August 8, 2026 02:13
staging-devin-ai-integration
Bot
force-pushed
the
devin/1786151607-block-replaced-sizing
branch
from
August 8, 2026 02:19
9e02773 to
8cfe721
Compare
This was referenced Aug 8, 2026
staging-devin-ai-integration
Bot
force-pushed
the
devin/1786151607-block-replaced-sizing
branch
from
August 8, 2026 02:34
8cfe721 to
cc929f6
Compare
staging-devin-ai-integration
Bot
changed the base branch from
main
to
devin/1786156433-img-object-dims
August 8, 2026 02:34
staging-devin-ai-integration
Bot
force-pushed
the
devin/1786151607-block-replaced-sizing
branch
from
August 13, 2026 17:30
cc929f6 to
7a93e6b
Compare
staging-devin-ai-integration
Bot
changed the base branch from
devin/1786156433-img-object-dims
to
main
August 13, 2026 17:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased on latest main; the intrinsic SVG sizing and img/object dimension-attribute work originally in this PR has since landed on main (e.g. #606, #643, #662), so what remains is the SVG content clipping fix.
SVG elements now participate in replaced-content clipping like raster images (fixes overflow bleed in e.g.
css/CSS2/positioning/absolute-replaced-width-003b.xhtandcss/css-overflow/display-flex-svg-overflow-default.html). Exception: an SVG containing backdrop-blending groups (mix-blend-modemapped by usvg) is not clipped, since the isolated buffer of a clip layer would make the blend composite against transparency instead of the page backdrop (css/compositing/mix-blend-mode/mix-blend-mode-svg.html):Also adds an
ElementData::svg_image_data()accessor returning the fullSvgImageData(used by #642, which is stacked on this PR).Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/51256d0b440341bd874c6dc59e138478
Requested by: @nicoburns