Re-pin parley for negative half-leading fix (WPT Group B) - #686
Open
nicoburns wants to merge 3 commits into
Open
Re-pin parley for negative half-leading fix (WPT Group B)#686nicoburns wants to merge 3 commits into
nicoburns wants to merge 3 commits into
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
staging-devin-ai-integration
Bot
force-pushed
the
devin/1786131935-parley-git-dep
branch
from
August 18, 2026 21:18
262905f to
7d1d6b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consumes DioxusLabs/parley#8 (rev
99ec3e5), which stops clamping negative line box extents produced by negative half-leading (line-height < ascent + descent), fixing thecss/CSS2/linebox/line-height-0xxWPT regression cluster on this branch.Parley's line extents now start at
f32::NEG_INFINITY(resolved to 0 for lines with no contributing content) instead of 0, somax-accumulation no longer floors legitimately-negativeover/underat zero. Out-of-flow inline boxes contributeNEG_INFINITYextents (no-op) instead of0.0; correspondingly, the float placement path ininline.rsnow passesNEG_INFINITYascent/descent toappend_inline_box_to_lineso floats no longer floor the line's extents (previously masked by the zero default, and would otherwise regressline-height-oof-descendants-001.html).WPT (
css/CSS2+css/css-fonts+css/css-text, vs this branch without the fix): 4685 → 4720 passing (+35 fixed, 0 regressions). Fixed: theline-height-0xxcluster,visudet/line-height-201.html,first-available-font-003/004.html. Not covered:inline-formatting-context-011.xht(passes onmain, still fails on this branch — it depends on inline-block/vertical-align line metrics, outside this fix's scope).Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/be0138f98f55445c85962594d089b88d
Requested by: @nicoburns
WPT results
33 newly passing, 53 newly failing (net -20).
Full diff (86 changed tests)
Generated by the WPT workflow.