Skip to content

Update taffy pin: grid container height transferred from width via aspect-ratio - #709

Open
nicoburns wants to merge 4 commits into
mainfrom
devin/1786660299-grid-aspect-ratio-height
Open

Update taffy pin: grid container height transferred from width via aspect-ratio#709
nicoburns wants to merge 4 commits into
mainfrom
devin/1786660299-grid-aspect-ratio-height

Conversation

@nicoburns

@nicoburns nicoburns commented Aug 13, 2026

Copy link
Copy Markdown
Member

Summary

Bumps the taffy pin to include DioxusLabs/taffy#1098, which transfers a grid container's automatic height from its used width via aspect-ratio (previously the height was derived from the row sum, ignoring the aspect ratio).

Fixes WPT css/css-grid/grid-definition/grid-auto-repeat-aspect-ratio-001.html:

<div style="display: inline-grid; aspect-ratio: 1/1; min-height: 60px;
            grid-template-columns: repeat(auto-fill, 50px);"></div>

The min-height transferred through the aspect ratio already produced the correct 2 auto-fill repetitions (100px width), but the used height then came out as 60px (max(row sum = 0, min-height)) instead of 100px transferred from the width.

The new taffy revision also includes the LayoutInput::known_dimensions_are_definite field from taffy#1091's follow-ups; the two LayoutInput constructions in blitz-dom's inline layout (for absolutely-positioned inline boxes, which always have a definite containing block) set it to true for both axes, matching taffy's own call sites.

Full flexbox+grid WPT comparison vs main: +2 passes (grid-auto-repeat-aspect-ratio-001.html, percentage-heights-008.html), no regressions.

Note: grid-auto-repeat-aspect-ratio-002.html still fails — it additionally requires width: min-content, and intrinsic sizing keywords are currently converted to auto in stylo_taffy (taffy's Dimension has no representation for them).

Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/d23708053506499cbb8d4515549f1753
Requested by: @nicoburns

WPT results

2 newly passing, 0 newly failing (net +2).

Full diff (2 changed tests)
+ Fail => Pass css/css-grid/grid-definition/grid-auto-repeat-aspect-ratio-001.html
+ Fail => Pass css/css-sizing/aspect-ratio/grid-aspect-ratio-align-items-center.html

Generated by the WPT workflow.

@staging-devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant