Implement text decoration styles (rebased) - #753
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
staging-devin-ai-integration
Bot
force-pushed
the
text-decoration-styles-rebased
branch
from
August 19, 2026 13:09
998e6c3 to
b2f357e
Compare
nicoburns
enabled auto-merge (squash)
August 19, 2026 13:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebase of #510 onto latest main (couldn't push to the fork branch, so opening as a new PR).
Implements:
SelectBestDashGap)Decorations are now accumulated per "decorating box" across a whole line (
LineDecorationkeyed by node id) and flushed once per line, so mixed font sizes within a box draw a single straight line rather than stepped per-run segments (matching Firefox). Overline/strikethrough placement uses the OS/2usWinAscent(via a newread-fontsdependency), matching browser behaviour.Rebase changes vs #510:
packages/blitz-paint/src/text.rsDecorationStackEntry,LineDecoration,path_scratch,stroke_text'sinline_root_id) changed fromusizeto theNodeIdnewtype introduced on mainVerified with
cargo check, clippy, fmt, and by renderingexamples/assets/text-decoration.htmlwith the screenshot example.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/1e40516b22b34e3d89abb619530f4b45
Requested by: @nicoburns
WPT results
18 newly passing, 11 newly failing (net +7).
Full diff (29 changed tests)
Generated by the WPT workflow.