Repository navigation
Update FolderInterface.php: Adding return type for better static analysis - #199
Open
ThomasLandauer wants to merge 1 commit into
Open
ThomasLandauer wants to merge 1 commit into
ThomasLandauer wants to merge 1 commit into
Conversation
…ysis I'm suggesting to add types for the array elements like this; for other arrays too. I haven't double-checked if those here are really correct for all cases.
stevebauman
reviewed
Nov 13, 2026
| @@ -68,6 +68,7 @@ public function quota(): array; | |||
|
|
|||
| /** | |||
| * Get the folder's status. | |||
| * @return array{'MESSAGES': string, 'RECENT': string, 'UIDNEXT': string, 'UIDVALIDITY': string, 'UNSEEN': string} | |||
Member
There was a problem hiding this comment.
Are we sure this is the case across all IMAP providers?
Author
There was a problem hiding this comment.
No. But since you're mentioning them at https://github.com/DirectoryTree/ImapEngine/blob/master/src/Connection/ConnectionInterface.php#L244 I was figuring that this would be some standard.
If not, what about @return array<string, string>? Or would it be possible that you convert the values to int, to get @return array<string, int>?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm suggesting to add types for the array elements like this; for other arrays too. I haven't double-checked if those here are really correct for all cases.