Repository navigation
Improve tokenizer performance for large IMAP responses - #201
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing large IMAP responses spends a significant amount of CPU time reading quoted strings, atoms, whitespace, and email addresses one byte at a time. Each byte requires several PHP method calls, even when the data is already buffered.
This updates those four readers to consume character runs using
strcspn()andstrspn(). The scanning stays directly in each reader, with explicit handling for escapes, delimiters, and incomplete input.Benchmarking a synthetic FETCH response containing 35,798 messages on PHP 8.4.27 produced the following parser CPU timings.
The reporter's Gmail response has not been benchmarked locally.
All 546 unit tests pass, along with 3,125 comparisons of token values, token types, and exception classes/messages against the original tokenizer.
Fixes #200.