More PHPStan level 6 cleanups, all remaining .inc files - #1613
Merged
Conversation
Some of these are less specific than they could be, and a few of these involve repeating array shapes that would probably be better done as DTOs. But it's a step in the right direction.
- Do a few renames where the function was misleading (should be format_foo because it returns a string, not showFoo) - Use bool instead of int=0/1 in a few places - Leave a few TODOs for later cleanups
cpeel
approved these changes
Aug 31, 2026
Also tweak some APIs where the types worked against us or were overly broad and update the callers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases this involves changing function signatures to be more restrictive (eg using
boolinstead of truthy values, etc).Some of this needs revisiting to refine it further, in particular the
api/ApiRouteruse ofarray<string ,mixed>for REST path arguments can probably benefit from shaped arrays; andProjectInfoHolder::row()needs a rototill.