More PHPStan level 6 cleanups, some *.php files - #1614
Merged
Conversation
And do some minor tidyup while here.
While here, change credits.php to use a CreditDetails DTO rather than repeating a shaped array in several PHPDocs or adding a type alias to phpstan.neon
Introducing a new function where it's difficult to express that a function based on `str_replace` can operate on strings or on associative array with string values. Do some minor tidyups too (although this code needs a lot more love)
This exposed some errors: - `GraphConfig`'s shape was too restrictive: data can be `int[]` depending on the chart type - `get_round_backlog_stats` had the wrong return type - A few `SELECT SUM(*)`s need guards for when no rows match - `stats/equilibria.php`'s days query param is unused.
cpeel
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly adding function type hints, but in a few cases we:
""instead ofnull) to match the intended behaivourfunc_get_args